linux-kernel - Re: [PATCH] samples/mic/mpssd: Remove duplicate header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFqtX7kYY-TSTKwov3jCN7nWDnjPHSFcDC+wkuawMDQj1Zx=eA@mail.gmail.com>
Date:   Wed, 30 Jan 2019 20:05:21 +0530
From:   Brajeswar Ghosh <brajeswar.linux@...il.com>
To:     akpm@...ux-foundation.org
Cc:     Souptick Joarder <jrdr.linux@...il.com>,
        linux-kernel@...r.kernel.org,
        Sabyasachi Gupta <sabyasachi.linux@...il.com>
Subject: Re: [PATCH] samples/mic/mpssd: Remove duplicate header

On Mon, Jan 14, 2019 at 10:30 PM Brajeswar Ghosh
<brajeswar.linux@...il.com> wrote:
>
> Remove duplicate headers which are included more than once
>
> Signed-off-by: Brajeswar Ghosh <brajeswar.linux@...il.com>

Any comment on this patch?

> ---
>  samples/mic/mpssd/mpssd.h | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/samples/mic/mpssd/mpssd.h b/samples/mic/mpssd/mpssd.h
> index 8bd64944aacc..82d3b519f0e7 100644
> --- a/samples/mic/mpssd/mpssd.h
> +++ b/samples/mic/mpssd/mpssd.h
> @@ -37,21 +37,18 @@
>  #include <sys/types.h>
>  #include <sys/socket.h>
>  #include <sys/stat.h>
> -#include <sys/types.h>
>  #include <sys/mman.h>
>  #include <sys/utsname.h>
>  #include <sys/wait.h>
>  #include <netinet/in.h>
>  #include <arpa/inet.h>
>  #include <netdb.h>
> -#include <pthread.h>
>  #include <signal.h>
>  #include <limits.h>
>  #include <syslog.h>
>  #include <getopt.h>
>  #include <net/if.h>
>  #include <linux/if_tun.h>
> -#include <linux/if_tun.h>
>  #include <linux/virtio_ids.h>
>
>  #define MICSYSFSDIR "/sys/class/mic"
> --
> 2.17.1
>