linux-kernel - Re: [PATCH net-next v6 1/2] net: add support for Cavium PTP coprocessor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190130150614.GA229773@google.com>
Date:   Wed, 30 Jan 2019 09:06:15 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Aleksey Makarov <aleksey.makarov@...ium.com>
Cc:     netdev@...r.kernel.org, Robert Richter <rric@...nel.org>,
        "Goutham, Sunil" <Sunil.Goutham@...ium.com>,
        Richard Cochran <richardcochran@...il.com>,
        Radoslaw Biernacki <rad@...ihalf.com>,
        linux-kernel@...r.kernel.org,
        David Daney <ddaney@...iumnetworks.com>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Joe Perches <joe@...ches.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next v6 1/2] net: add support for Cavium PTP
 coprocessor

On Mon, Jan 15, 2018 at 06:44:56PM +0600, Aleksey Makarov wrote:
> +++ b/drivers/net/ethernet/cavium/common/cavium_ptp.c
> @@ -0,0 +1,353 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* cavium_ptp.c - PTP 1588 clock on Cavium hardware
> + * Copyright (c) 2003-2015, 2017 Cavium, Inc.
> + */
> +
> +#include <linux/device.h>
> +#include <linux/module.h>
> +#include <linux/timecounter.h>
> +#include <linux/pci.h>
> +
> +#include "cavium_ptp.h"
> +
> +#define DRV_NAME	"Cavium PTP Driver"

This is also unconventional and looks funny, e.g., here:

  $ ls /sys/bus/pci/drivers/
   8250_mid/             exar_serial/         mei_me/       snd_hda_intel/
   agpgart-intel/        i801_smbus/          parport_pc/   snd_soc_skl/
   agpgart-sis/          i915/                pcieport/     xen-platform-pci/
   agpgart-via/          intel_ish_ipc/       rtsx_pci/     xhci_hcd/
   ahci/                 intel_pch_thermal/   serial/
  'Cavium PTP Driver'/   iosf_mbi_pci/        shpchp/
   e1000e/               iwlwifi/             skl_uncore/