linux-kernel - Re: [PATCH] drm/bridge/panel: Remove duplicate header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 Jan 2019 20:45:18 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     Brajeswar Ghosh <brajeswar.linux@...il.com>
Cc:     Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Archit Taneja <architt@...eaurora.org>, a.hajda@...sung.com,
        airlied@...ux.ie, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org,
        Sabyasachi Gupta <sabyasachi.linux@...il.com>
Subject: Re: [PATCH] drm/bridge/panel: Remove duplicate header

On Wed, Jan 30, 2019 at 8:07 PM Brajeswar Ghosh
<brajeswar.linux@...il.com> wrote:
>
> On Wed, Dec 26, 2018 at 3:09 PM Laurent Pinchart
> <laurent.pinchart@...asonboard.com> wrote:
> >
> > Hi Brajeswar,
> >
> > Thank you for the patch.
> >
> > On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote:
> > > Remove drm/drm_panel.h which is included more than once
> > >
> > > Signed-off-by: Brajeswar Ghosh <brajeswar.linux@...il.com>
> > > ---
> > >  drivers/gpu/drm/bridge/panel.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> > > index 7cbaba213ef6..402b318eeeb2 100644
> > > --- a/drivers/gpu/drm/bridge/panel.c
> > > +++ b/drivers/gpu/drm/bridge/panel.c
> > > @@ -15,7 +15,6 @@
> > >  #include <drm/drm_crtc_helper.h>
> > >  #include <drm/drm_encoder.h>
> > >  #include <drm/drm_modeset_helper_vtables.h>
> > > -#include <drm/drm_panel.h>
> >
> > While at it, how about sorting headers alphabetically to make sure this won't
> > happen again ?
> >
> > With that change,
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
>
> If no further comment, can we get this patch in queue for 5.1 ?

You already got a feedback from Laurent.
>
> >
> > >  struct panel_bridge {
> > >       struct drm_bridge bridge;
> >
> > --
> > Regards,
> >
> > Laurent Pinchart
> >
> >
> >