linux-kernel - Re: [PATCH] net: wireless: prefix header search paths with $(srctree)/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <883460220.650537.1548861942189@mail.yahoo.com>
Date:   Wed, 30 Jan 2019 15:25:42 +0000 (UTC)
From:   Hin-Tak Leung <htl10@...rs.sourceforge.net>
To:     Kalle Valo <kvalo@...eaurora.org>,
        <linux-wireless@...r.kernel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     <netdev@...r.kernel.org>, Larry Finger <Larry.Finger@...inger.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: wireless: prefix header search paths with
 $(srctree)/

--------------------------------------------
On Fri, 25/1/19, Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:
 
> Currently, the Kbuild core manipulates header
> search paths in a crazy
> way [1].
 
> To fix this mess, I want all Makefiles
> to add explicit $(srctree)/ to
> the search paths in the srctree. Some
> Makefiles are already written in
> that way, but not all. The goal of this
> work is to make the notation
> consistent, and finally get rid of the
> gross hacks.
 
> Having whitespaces after -I does not
> matter since commit 48f6e3cf5bc6
> ("kbuild: do not drop -I without
> parameter").
 
> I also removed one header search path
> in:
 
  
> drivers/net/wireless/broadcom/brcm80211/brcmutil/Makefile
 
> I was able to compile without it.
 
> [1]: https://patchwork.kernel.org/patch/9632347/
 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Acked-by: Hin-Tak Leung <htl10@...rs.sourceforge.net>

Looks okay for the rtl818x parts.