linux-kernel - RE: [PATCH v4 1/3] scsi: ufs-bsg: Change the calling convention for write descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <BYAPR08MB453398C5D7BD52EB90A36096DB900@BYAPR08MB4533.namprd08.prod.outlook.com>
Date:   Wed, 30 Jan 2019 14:53:14 +0000
From:   "Bean Huo (beanhuo)" <beanhuo@...ron.com>
To:     Avri Altman <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Evan Green <evgreen@...omium.org>
CC:     Avi Shchislowski <avi.shchislowski@....com>,
        Alex Lemberg <alex.lemberg@....com>
Subject: RE:  [PATCH v4 1/3] scsi: ufs-bsg: Change the calling convention for
 write descriptor

Hi, Avri

>
>When we had a write descriptor query upiu, we appended the descriptor right
>after the bsg request.  This was fine as the bsg driver allows to allocate whatever
>buffer we needed in its job request.
>
>Still, the proper way to deliver payload, however small (we only write config
>descriptors of 144 bytes), is by using the job request payload data buffer.
>
>So change this ABI now, while ufs-bsg is still new, and nobody is actually using it.
>
>Signed-off-by: Avri Altman <avri.altman@....com>
>Reviewed-by: Evan Green <evgreen@...omium.org>
>---
> Documentation/scsi/ufs.txt |  6 ++++++
> drivers/scsi/ufs/ufs_bsg.c | 47 +++++++++++++++++++++++++---------------------
> 2 files changed, 32 insertions(+), 21 deletions(-)
>
>diff --git a/Documentation/scsi/ufs.txt b/Documentation/scsi/ufs.txt index
>520b5b0..78fe7cb 100644
>--- a/Documentation/scsi/ufs.txt
>+++ b/Documentation/scsi/ufs.txt
>@@ -147,6 +147,12 @@ send SG_IO with the applicable sg_io_v4:
> 	io_hdr_v4.max_response_len = reply_len;
> 	io_hdr_v4.request_len = request_len;
> 	io_hdr_v4.request = (__u64)request_upiu;
>+	if (dir == SG_DXFER_TO_DEV) {
>+		io_hdr_v4.dout_xfer_len = (uint32_t)byte_cnt;
>+		io_hdr_v4.dout_xferp = (uintptr_t)(__u64)buff;
>+	}
>+
>+If you wish to write a descriptor, use the dout_xferp sg_io_v4.
>
> UFS Specifications can be found at,
> UFS - http://www.jedec.org/sites/default/files/docs/JESD220.pdf
>diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c index
>775bb4e..2fd0769 100644
>--- a/drivers/scsi/ufs/ufs_bsg.c
>+++ b/drivers/scsi/ufs/ufs_bsg.c
>@@ -27,15 +27,11 @@ static int ufs_bsg_get_query_desc_size(struct ufs_hba
>*hba, int *desc_len,
>
> static int ufs_bsg_verify_query_size(struct ufs_hba *hba,
> 				     unsigned int request_len,
>-				     unsigned int reply_len,
>-				     int desc_len, enum query_opcode desc_op)
>+				     unsigned int reply_len)
> {
> 	int min_req_len = sizeof(struct ufs_bsg_request);
> 	int min_rsp_len = sizeof(struct ufs_bsg_reply);
>
>-	if (desc_op == UPIU_QUERY_OPCODE_WRITE_DESC)
>-		min_req_len += desc_len;
>-
> 	if (min_req_len > request_len || min_rsp_len > reply_len) {
> 		dev_err(hba->dev, "not enough space assigned\n");
> 		return -EINVAL;
>@@ -44,14 +40,13 @@ static int ufs_bsg_verify_query_size(struct ufs_hba *hba,
> 	return 0;
> }
>
>-static int ufs_bsg_verify_query_params(struct ufs_hba *hba,
>-				       struct ufs_bsg_request *bsg_request,
>-				       unsigned int request_len,
>-				       unsigned int reply_len,
>-				       uint8_t *desc_buff, int *desc_len,
>-				       enum query_opcode desc_op)
>+static int ufs_bsg_alloc_desc_buffer(struct ufs_hba *hba, struct bsg_job *job,
>+				     uint8_t **desc_buff, int *desc_len,

Maybe here also we should use 'u8'.

Reviewed-by: Bean Huo <beanhuo@...nhuo@...ron.com>

//Beanhuo