[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190130154922.GO32526@8bytes.org>
Date: Wed, 30 Jan 2019 16:49:23 +0100
From: Joerg Roedel <joro@...tes.org>
To: "Lendacky, Thomas" <Thomas.Lendacky@....com>
Cc: "Michael S . Tsirkin" <mst@...hat.com>,
Jason Wang <jasowang@...hat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
"virtualization@...ts.linux-foundation.org"
<virtualization@...ts.linux-foundation.org>,
"linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
"jfehlig@...e.com" <jfehlig@...e.com>,
"Grimm, Jon" <Jon.Grimm@....com>,
"Singh, Brijesh" <brijesh.singh@....com>,
"jroedel@...e.de" <jroedel@...e.de>
Subject: Re: [PATCH 4/5] virtio: Introduce virtio_max_dma_size()
Hi Tom,
On Wed, Jan 30, 2019 at 03:10:29PM +0000, Lendacky, Thomas wrote:
> On 1/29/19 2:43 AM, Joerg Roedel wrote:
> > +size_t virtio_max_dma_size(struct virtio_device *vdev)
> > +{
> > + size_t max_segment_size = SIZE_MAX;
> > +
> > + if (vring_use_dma_api(vdev))
> > + max_segment_size = dma_max_mapping_size(&vdev->dev);
> > +
> > + return max_segment_size;
> > +}
>
> When I build with these patches and with the virtio devices as modules I
> get a build failure. Looks like this needs an EXPORT_SYMBOL_GPL().
Thanks for pointing that out, I added the missing EXPORTs and will send
a new version shortly.
Regards,
Joerg
Powered by blists - more mailing lists