lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 30 Jan 2019 08:54:09 -0700
From:   Jens Axboe <>
To:     Jianchao Wang <>
Subject: Re: [PATCH] blk-mq: fix a hung issue when fsync

On 1/30/19 2:01 AM, Jianchao Wang wrote:
> Florian reported a io hung issue when fsync(). It should be
> triggered by following race condition.
> data + post flush         a flush
> blk_flush_complete_seq
>   case REQ_FSEQ_DATA
>     blk_flush_queue_rq
>     issued to driver      blk_mq_dispatch_rq_list
>                             try to issue a flush req
>                             failed due to NON-NCQ command
>                             .queue_rq return BLK_STS_DEV_RESOURCE
> request completion
>   req->end_io // doesn't check RESTART
>   mq_flush_data_end_io
>       blk_kick_flush
>         do nothing because previous flush
>         has not been completed
>      blk_mq_run_hw_queue
>                               insert rq to hctx->dispatch
>                               due to RESTART is still set, do nothing
> To fix this, replace the blk_mq_run_hw_queue in mq_flush_data_end_io
> with blk_mq_sched_restart to check and clear the RESTART flag.

Applied, thanks.

Jens Axboe

Powered by blists - more mailing lists