linux-kernel - Re: [PATCH] drm/savage: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190130163535.GH3271@phenom.ffwll.local>
Date:   Wed, 30 Jan 2019 17:35:35 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/savage: mark expected switch fall-throughs

On Tue, Jan 29, 2019 at 02:20:06PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> This patch fixes the following warnings:
> 
> drivers/gpu/drm/savage/savage_state.c:301:8: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/gpu/drm/savage/savage_state.c:438:8: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/gpu/drm/savage/savage_state.c:559:8: warning: this statement may fall through [-Wimplicit-fallthrough=]
> drivers/gpu/drm/savage/savage_state.c:697:8: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> This patch is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

This and the via patch merged to drm-misc-next, thanks.
-Daniel

> ---
>  drivers/gpu/drm/savage/savage_state.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/savage/savage_state.c b/drivers/gpu/drm/savage/savage_state.c
> index 7559a820bd43..ebb8b7d32b33 100644
> --- a/drivers/gpu/drm/savage/savage_state.c
> +++ b/drivers/gpu/drm/savage/savage_state.c
> @@ -299,6 +299,7 @@ static int savage_dispatch_dma_prim(drm_savage_private_t * dev_priv,
>  	case SAVAGE_PRIM_TRILIST_201:
>  		reorder = 1;
>  		prim = SAVAGE_PRIM_TRILIST;
> +		/* fall through */
>  	case SAVAGE_PRIM_TRILIST:
>  		if (n % 3 != 0) {
>  			DRM_ERROR("wrong number of vertices %u in TRILIST\n",
> @@ -436,6 +437,7 @@ static int savage_dispatch_vb_prim(drm_savage_private_t * dev_priv,
>  	case SAVAGE_PRIM_TRILIST_201:
>  		reorder = 1;
>  		prim = SAVAGE_PRIM_TRILIST;
> +		/* fall through */
>  	case SAVAGE_PRIM_TRILIST:
>  		if (n % 3 != 0) {
>  			DRM_ERROR("wrong number of vertices %u in TRILIST\n",
> @@ -557,6 +559,7 @@ static int savage_dispatch_dma_idx(drm_savage_private_t * dev_priv,
>  	case SAVAGE_PRIM_TRILIST_201:
>  		reorder = 1;
>  		prim = SAVAGE_PRIM_TRILIST;
> +		/* fall through */
>  	case SAVAGE_PRIM_TRILIST:
>  		if (n % 3 != 0) {
>  			DRM_ERROR("wrong number of indices %u in TRILIST\n", n);
> @@ -695,6 +698,7 @@ static int savage_dispatch_vb_idx(drm_savage_private_t * dev_priv,
>  	case SAVAGE_PRIM_TRILIST_201:
>  		reorder = 1;
>  		prim = SAVAGE_PRIM_TRILIST;
> +		/* fall through */
>  	case SAVAGE_PRIM_TRILIST:
>  		if (n % 3 != 0) {
>  			DRM_ERROR("wrong number of indices %u in TRILIST\n", n);
> -- 
> 2.20.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch