linux-kernel - Re: [PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B6DFDA82-F72C-4979-B988-05C292E61228@fb.com>
Date:   Wed, 30 Jan 2019 18:01:22 +0000
From:   Vijay Khemka <vijaykhemka@...com>
To:     Joel Stanley <joel@....id.au>
CC:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Andrew Jeffery <andrew@...id.au>,
        devicetree <devicetree@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        "openbmc @ lists . ozlabs . org" <openbmc@...ts.ozlabs.org>
Subject: Re: [PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook



On 1/29/19, 7:27 PM, "Joel Stanley" <joel@....id.au> wrote:

    On Thu, 24 Jan 2019 at 10:07, Vijay Khemka <vijaykhemka@...com> wrote:
    
    > index 73e58a821613..d60dbb019f82 100644
    > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
    
    >
    > +&peci0 {
    > +       status = "okay";
    > +};
    
    I don't think we have an upstream tree that contains a node called
    peci0. Therefore this does not build.
    
    I have dropped this hunk from your patch. Please make sure you test
    before sending patches.
Thanks Joel, I will be careful.
    
    Cheers,
    
    Joel