linux-kernel - Re: [PATCH] x86/mm: Add SPDX identifier in arch/x86/mm files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1901301900400.1622@nanos.tec.linutronix.de>
Date:   Wed, 30 Jan 2019 19:05:35 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Liu Xiang <liu.xiang6@....com.cn>
cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        dave.hansen@...ux.intel.com, luto@...nel.org, peterz@...radead.org,
        mingo@...hat.com, bp@...en8.de, hpa@...or.com,
        liuxiang_1999@....com
Subject: Re: [PATCH] x86/mm: Add SPDX identifier in arch/x86/mm files

On Wed, 30 Jan 2019, Liu Xiang wrote:
> --- a/arch/x86/mm/iomap_32.c
> +++ b/arch/x86/mm/iomap_32.c
> @@ -1,19 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0

This is wrong.

>  /*
>   * Copyright © 2008 Ingo Molnar
>   *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.

      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

And there are more of those wrongs.

Aside of that, you really need to differentiate between files, which do not
have any license notice or reference at all and those which have. For the
ones without adding the identifier is fine. For thos which have, you really
need to create separate patches and cc the copyright holder(s) and the
initial author if possible.

Just slapping random identifiers into source files is not helping anything,
actually it's making the problem worse because you are relicensing the
source files.

Thanks,

	tglx