linux-kernel - Re: [PATCH] drm/amdkfd: Fix if preprocessor statement above kfd_fill_iolink_info_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a6ce2e6-620e-ca73-d21d-207c8f9248ce@amd.com>
Date:   Thu, 31 Jan 2019 20:10:05 +0000
From:   "Kuehling, Felix" <Felix.Kuehling@....com>
To:     Nathan Chancellor <natechancellor@...il.com>,
        Oded Gabbay <oded.gabbay@...il.com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Zhou, David(ChunMing)" <David1.Zhou@....com>
CC:     Mark Nutter <Mark.Nutter@....com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amdkfd: Fix if preprocessor statement above
 kfd_fill_iolink_info_for_cpu

Thank you, Nathan. I applied your patch to amd-staging-drm-next.

Sorry for the late response. I'm catching up with my email backlog after 
a vacation.

Regards,
   Felix

On 2019-01-21 6:52 p.m., Nathan Chancellor wrote:
> Clang warns:
>
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:866:5: warning:
> 'CONFIG_X86_64' is not defined, evaluates to 0 [-Wundef]
> #if CONFIG_X86_64
>      ^
> 1 warning generated.
>
> Fixes: d1c234e2cd10 ("drm/amdkfd: Allow building KFD on ARM64 (v2)")
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
>
> Resending as I forgot to add the lists...
>
>   drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index 5d85ff341385..2e7c44955f43 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -863,7 +863,7 @@ static int kfd_fill_mem_info_for_cpu(int numa_node_id, int *avail_size,
>   	return 0;
>   }
>   
> -#if CONFIG_X86_64
> +#ifdef CONFIG_X86_64
>   static int kfd_fill_iolink_info_for_cpu(int numa_node_id, int *avail_size,
>   				uint32_t *num_entries,
>   				struct crat_subtype_iolink *sub_type_hdr)