linux-kernel - Re: [PATCH v8 5/7] tpm: move tpm_chip definition to include/linux/tpm.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 31 Jan 2019 08:54:50 +0100
From:   Roberto Sassu <roberto.sassu@...wei.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
CC:     <zohar@...ux.ibm.com>, <david.safford@...com>,
        <monty.wiseman@...com>, <matthewgarrett@...gle.com>,
        <linux-integrity@...r.kernel.org>,
        <linux-security-module@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <keyrings@...r.kernel.org>,
        <silviu.vlasceanu@...wei.com>
Subject: Re: [PATCH v8 5/7] tpm: move tpm_chip definition to
 include/linux/tpm.h

On 1/29/2019 9:34 PM, Jarkko Sakkinen wrote:
> On Thu, Jan 24, 2019 at 04:49:08PM +0100, Roberto Sassu wrote:
>> -enum tpm_const {
>> -	TPM_MINOR = 224,	/* officially assigned */
>> -	TPM_BUFSIZE = 4096,
>> -	TPM_NUM_DEVICES = 65536,
>> -	TPM_RETRY = 50,		/* 5 seconds */
>> -	TPM_NUM_EVENT_LOG_FILES = 3,
>> -};
> 
> Here using enum has been a bad idea in the first place, as they don't
> relate in any meaningful way.
> 
> Replace the definition with the following in drivers/char/tpm/tpm.h:
> 
> #define TPM_MINOR	224 /* misc backwards compatibility */
> #define TPM_BUFSIZE	4096
> #define TPM_NUM_DEVICES	65536
> #define TPM_RETRY	5 /* seconds */

Is 5 correct? TPM_RETRY was 50 before.

Roberto


> And only add this to include/linux/tpm.h:
> 
> #define TPM_NUM_EVENT_LOG_FILES 3
> 
> Otherwise, this looks good.
> 
> /Jarkko
> 

-- 
HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063
Managing Director: Bo PENG, Jian LI, Yanli SHI