linux-kernel - Re: [PATCH v7 0/3] Move pm_runtime accounted time to raw nsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKfTPtBo745LS1hy7PHLOUG3cp_bWxaRXnq0EKDJeLptUuwH9A@mail.gmail.com>
Date:   Thu, 31 Jan 2019 09:06:48 +0100
From:   Vincent Guittot <vincent.guittot@...aro.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thara Gopinath <thara.gopinath@...aro.org>,
        Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH v7 0/3] Move pm_runtime accounted time to raw nsec

On Thu, 31 Jan 2019 at 08:44, Ulf Hansson <ulf.hansson@...aro.org> wrote:
>
> On Thu, 31 Jan 2019 at 00:51, Rafael J. Wysocki <rjw@...ysocki.net> wrote:
> >
> > On Wednesday, January 23, 2019 8:50:12 AM CET Vincent Guittot wrote:
> > > Move pm_runtime accounted time to raw nsec. The subject of the patchset
> > > has changed as 1st patch o the previous versions has been queued by
> > > Rafael.
> > >
> > > Patch 1 set accounting_timestamp to 0 in pm_runtime_init and update it when enable.
> > > So we remove ordering constraint between timekeeping_init and pm_runtime_init
> > >
> > > Patch 2 moves time accounting on raw ns. This patch initially used
> > > ktime instead of raw ns but it was easier to move i915 driver on raw ns
> > > than on ktime.
> > >
> > > Change since v6:
> > > - move code that set accounting_timestamp in pm_runtime_enable
> > >
> > > Changes since v5:
> > > - removed patches already queued.
> > > - set accounting_timestamp to 0 in pm_runtime_init and update it when enable
> > >
> > > Changes since v4:
> > > -Update commit message
> > >
> > > Changes since v3:
> > > - Rebase on v4.20-rc7 without patch that has been queued by Rafael
> > > - Simplify the new interface pm_runtime_suspended_time()
> > >
> > > Changes since v2:
> > > - remove patch1 that has been queued by rafael
> > > - add new interface in pm_runtime to get accounted time
> > > - reorder patchset to prevent compilation error
> > >
> > > Changes since v1:
> > > - updated commit message of patch 1
> > > - Added patches 2 & 3 to move runtime_pm accounting on raw ns
> > >
> > > Thara Gopinath (1):
> > >   PM-runtime: Replace jiffies based accounting with ktime-based
> > >     accounting
> > >
> > > Vincent Guittot (1):
> > >   PM-runtime: update accounting_timestamp only when enable
> > >
> > >  drivers/base/power/runtime.c | 26 ++++++++++++++++----------
> > >  drivers/base/power/sysfs.c   | 11 ++++++++---
> > >  include/linux/pm.h           |  6 +++---
> > >  3 files changed, 27 insertions(+), 16 deletions(-)
> >
> > Both patches applied, thanks!
> >
>
> I had some comment on v6, none that needs to prevent this from being
> applied and that can't be addressed as improvements on top.

I had put this on hold until fixing regression with hrtimer but i'm
going to restart these improvements

>
> Feel free to add (if not too late) my:
>
> Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>
>
> Kind regards
> Uffe