linux-kernel - Re: [PATCH 3/6] drivers/IB,qib: do not use mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190131100400.GC19222@quack2.suse.cz>
Date:   Thu, 31 Jan 2019 11:04:00 +0100
From:   Jan Kara <jack@...e.cz>
To:     "Weiny, Ira" <ira.weiny@...el.com>
Cc:     'Jason Gunthorpe' <jgg@...pe.ca>,
        Davidlohr Bueso <dave@...olabs.net>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "dledford@...hat.com" <dledford@...hat.com>,
        "jack@...e.de" <jack@...e.de>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Dalessandro, Dennis" <dennis.dalessandro@...el.com>,
        "Marciniszyn, Mike" <mike.marciniszyn@...el.com>,
        Davidlohr Bueso <dbueso@...e.de>
Subject: Re: [PATCH 3/6] drivers/IB,qib: do not use mmap_sem

On Wed 30-01-19 18:01:33, Weiny, Ira wrote:
> > 
> > On Tue, Jan 29, 2019 at 10:50:05AM -0800, Ira Weiny wrote:
> > > > .. and I'm looking at some of the other conversions here.. *most
> > > > likely* any caller that is manipulating rlimit for get_user_pages
> > > > should really be calling get_user_pages_longterm, so they should not
> > > > be converted to use _fast?
> > >
> > > Is this a question?  I'm not sure I understand the meaning here?
> > 
> > More an invitation to disprove the statement
> 
> Generally I agree.  But would be best if we could get fast GUP for
> performance.  I have not worked out if that will be possible with the
> final "longterm" solutions.

Initially probably not, longer-term it might be added if there are
performance data supporting that (i.e., showing real workload that would
benefit). In principle there's nothing that would prevent gup_fast like
functionality for long-term pins but I expect there will be always
additional overhead (compared to plain gup_fast()) of establishing
something like leases to identify long-term pins. But we haven't figured
out the details yet. For now we concentrate on fixing short-term pins and
issues with those.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR