linux-kernel - Re: [PATCH] wcd9335: Remove unnecessary null checks in wcd9335_set_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eac1b134-8d9e-21d4-d749-b40b98348eff@linaro.org>
Date:   Thu, 31 Jan 2019 10:53:45 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Nathan Chancellor <natechancellor@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>
Cc:     Vinod Koul <vkoul@...nel.org>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wcd9335: Remove unnecessary null checks in
 wcd9335_set_channel_map

Thanks for the patch!

On 29/01/2019 21:48, Nathan Chancellor wrote:
> Clang warns:
> 
> sound/soc/codecs/wcd9335.c:2004:11: warning: address of array
> 'wcd->rx_chs' will always evaluate to 'true' [-Wpointer-bool-conversion]
>          if (wcd->rx_chs) {
>          ~~  ~~~~~^~~~~~
> sound/soc/codecs/wcd9335.c:2012:11: warning: address of array
> 'wcd->tx_chs' will always evaluate to 'true' [-Wpointer-bool-conversion]
>          if (wcd->tx_chs) {
>          ~~  ~~~~~^~~~~~
> 2 warnings generated.
> 
> Fixes: 20aedafdf492 ("ASoC: wcd9335: add support to wcd9335 codec")
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>