linux-kernel - Re: [PATCH] soc: qcom: update config dependencies for QCOM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190131013244.GC27190@builder>
Date:   Wed, 30 Jan 2019 17:32:44 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Stephen Boyd <swboyd@...omium.org>, Rob Herring <robh@...nel.org>,
        Alexander Graf <agraf@...e.de>
Cc:     Rajendra Nayak <rnayak@...eaurora.org>, andy.gross@...aro.org,
        david.brown@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux@...ck-us.net
Subject: Re: [PATCH] soc: qcom: update config dependencies for QCOM_RPMPD

On Fri 18 Jan 09:39 PST 2019, Stephen Boyd wrote:

> Quoting Rajendra Nayak (2019-01-17 20:48:01)
> >  drivers/soc/qcom/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> > index a5d5167c3f16..1ee298f6bf17 100644
> > --- a/drivers/soc/qcom/Kconfig
> > +++ b/drivers/soc/qcom/Kconfig
> > @@ -109,7 +109,7 @@ config QCOM_RPMHPD
> >  
> >  config QCOM_RPMPD
> >         bool "Qualcomm RPM Power domain driver"
> 
> Just curious, does it need to be bool for some reason?
> 

It's unfortunately not possible to have any genpd, iommu or pinctrl
drivers compiled as modules, because once you pass lateinit probe
deferral is purposefully broken. See
driver_deferred_probe_check_state().

This also means that if you're unlucky and your kernel reached lateinit
before the SMD communication with RPM is established and has brought up
the rpmpd, you are left with a completely broken system. Unfortunately
this isn't that hard to reproduce with a minimal defconfig.

Regards,
Bjorn