linux-kernel - Re: [PATCH 1/1] kernfs: Allocating memory for kernfs_iattrs with kmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190131123205.GA20404@kroah.com>
Date:   Thu, 31 Jan 2019 13:32:05 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ayush Mittal <ayush.m@...sung.com>
Cc:     tj@...nel.org, linux-kernel@...r.kernel.org, pankaj.m@...sung.com,
        a.sahrawat@...sung.com, v.narang@...sung.com
Subject: Re: [PATCH 1/1] kernfs: Allocating memory for kernfs_iattrs with
 kmem_cache.

On Thu, Jan 31, 2019 at 03:13:05PM +0530, Ayush Mittal wrote:
> @@ -414,4 +414,9 @@ void __init kernfs_init(void)
>  					      0,
>  					      SLAB_PANIC | SLAB_TYPESAFE_BY_RCU,
>  					      NULL);
> +	kernfs_iattrs_cache  = kmem_cache_create("kernfs_iattrs_cache",
> +					      sizeof(struct kernfs_iattrs),
> +					      0,
> +					      SLAB_PANIC | SLAB_TYPESAFE_BY_RCU,
> +					      NULL);
>  }

Are you sure the comment above this holds true for this new cache as
well?  Please document it as well as the other one was, and remove the
SLAB_ flags as needed.

thanks,

greg k-h