linux-kernel - Re: actx not used?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d8a940a-d903-5bf4-9e83-5a1a4d62a6de@schaufler-ca.com>
Date:   Wed, 30 Jan 2019 17:46:00 -0800
From:   Casey Schaufler <casey@...aufler-ca.com>
To:     Richard Guy Briggs <rgb@...hat.com>,
        Linux-Audit Mailing List <linux-audit@...hat.com>,
        Linux Security Module list 
        <linux-security-module@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: actx not used?

On 1/30/2019 4:58 PM, Richard Guy Briggs wrote:
> Hello users of *audit_rule_match(),
>
> As far as I can tell, it appears that the audit_context *actx parameter
> to *audit_rule_match() is not used by any consumers in-tree upstream.
> This includes selinux, apparmour, integrity and smack.
> Might there be others out of tree that do use it (or did request it)?
>
> I'm a bit puzzled that it was ever offered since it should be relatively
> opaque and accessed only by audit or its accessor functions.
>
> It was part of the 2008 commit 03d37d25e0f9 ("LSM/Audit: Introduce
> generic Audit LSM hooks").
>
> Would anyone object if I ripped out actx?

I don't see any reason to keep it based on what I see.
I don't see what it was supposed to be for, either.

> - RGB
>
> --
> Richard Guy Briggs <rgb@...hat.com>
> Sr. S/W Engineer, Kernel Security, Base Operating Systems
> Remote, Ottawa, Red Hat Canada
> IRC: rgb, SunRaycer
> Voice: +1.647.777.2635, Internal: (81) 32635
>