linux-kernel - Re: [PATCH] irqchip/gic-v3-its: Fix probing for ITT_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b25b4419-d552-4829-027f-3b676afc7fbf@arm.com>
Date:   Thu, 31 Jan 2019 12:48:32 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Zenghui Yu <yuzenghui@...wei.com>
Cc:     wanghaibin.wang@...wei.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip/gic-v3-its: Fix probing for ITT_entry_size

On 31/01/2019 11:19, Zenghui Yu wrote:
> According to ARM IHI 0069C (ID070116), we should use GITS_TYPER's
> bits [7:4] as ITT_entry_size.
> 
> Signed-off-by: Zenghui Yu <yuzenghui@...wei.com>
> ---
>  include/linux/irqchip/arm-gic-v3.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/irqchip/arm-gic-v3.h b/include/linux/irqchip/arm-gic-v3.h
> index 071b4cb..c848a7c 100644
> --- a/include/linux/irqchip/arm-gic-v3.h
> +++ b/include/linux/irqchip/arm-gic-v3.h
> @@ -319,7 +319,7 @@
>  #define GITS_TYPER_PLPIS		(1UL << 0)
>  #define GITS_TYPER_VLPIS		(1UL << 1)
>  #define GITS_TYPER_ITT_ENTRY_SIZE_SHIFT	4
> -#define GITS_TYPER_ITT_ENTRY_SIZE(r)	((((r) >> GITS_TYPER_ITT_ENTRY_SIZE_SHIFT) & 0x1f) + 1)
> +#define GITS_TYPER_ITT_ENTRY_SIZE(r)	((((r) >> GITS_TYPER_ITT_ENTRY_SIZE_SHIFT) & 0xf) + 1)
>  #define GITS_TYPER_IDBITS_SHIFT		8
>  #define GITS_TYPER_DEVBITS_SHIFT	13
>  #define GITS_TYPER_DEVBITS(r)		((((r) >> GITS_TYPER_DEVBITS_SHIFT) & 0x1f) + 1)
> 

Well spotted. I've applied this as a fix after having added the relevant
Fixes: tag and massaged the commit message a bit.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...