linux-kernel - Re: [PATCH v2] Bluetooth: Add NULL check for tiocmget() and tiocmset()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 31 Jan 2019 16:40:00 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Myungho Jung <mhjungk@...il.com>
Cc:     Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Bluetooth: Add NULL check for tiocmget() and
 tiocmset()

On Tue, Jan 29, 2019 at 09:39:28PM -0800, Myungho Jung wrote:
> tiocmget() and tiocmset() operations are optional and some tty drivers
> like pty miss the operations. We need NULL check to prevent from
> dereference.
> 
> Signed-off-by: Myungho Jung <mhjungk@...il.com>
> ---
>  drivers/bluetooth/hci_ath.c   | 6 ++++++
>  drivers/bluetooth/hci_ldisc.c | 4 ++++
>  2 files changed, 10 insertions(+)

Ah, you had already submitted a v2.

I still suggest splitting this one in two patches and that you add a
Fixes and stable tag to each so that they both get backported to stable.

Also, when resubmitting, make sure to include a short changelog here
below the cut-off line (---).

> 
> diff --git a/drivers/bluetooth/hci_ath.c b/drivers/bluetooth/hci_ath.c
> index d568fbd94d6c..fb9f6323a911 100644
> --- a/drivers/bluetooth/hci_ath.c
> +++ b/drivers/bluetooth/hci_ath.c
> @@ -185,8 +185,14 @@ static int ath_set_bdaddr(struct hci_dev *hdev, const bdaddr_t *bdaddr)
>  
>  static int ath_setup(struct hci_uart *hu)
>  {
> +	struct tty_struct *tty = hu->tty;
> +
>  	BT_DBG("hu %p", hu);
>  
> +	/* tty driver should support operations to set RTS */
> +	if (!tty->driver->ops->tiocmget || !tty->driver->ops->tiocmset)
> +		return -EOPNOTSUPP;

-ENODEV might be more appropriate.

Johan