linux-kernel - Re: [PATCHv6 6/6] coresight: debug: Add Unique Component Identifier (UCI) table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <154895230081.169292.7994428901781990604@swboyd.mtv.corp.google.com>
Date:   Thu, 31 Jan 2019 08:31:40 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andy Gross <andy.gross@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Doug Anderson <dianders@...omium.org>,
        Jeffrey Hugo <jhugo@...eaurora.org>,
        Leo Yan <leo.yan@...aro.org>,
        Marc Gonzalez <marc.w.gonzalez@...e.fr>,
        Mark Rutland <mark.rutland@....com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Mike Leach <mike.leach@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Vivek Gautam <vivek.gautam@...eaurora.org>,
        devicetree@...r.kernel.org
Cc:     Rajendra Nayak <rnayak@...eaurora.org>,
        Sibi Sankar <sibis@...eaurora.org>,
        Tingwei Zhang <tingwei@...eaurora.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org,
        Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>
Subject: Re: [PATCHv6 6/6] coresight: debug: Add Unique Component Identifier (UCI) table

Quoting Sai Prakash Ranjan (2019-01-31 06:22:24)
> diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> index e8819d750938..915d86a39cee 100644
> --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
> +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> @@ -655,24 +655,23 @@ static int debug_remove(struct amba_device *adev)
>         return 0;
>  }
>  
> +static struct amba_cs_uci_id uci_id_debug[] = {

Can this be const?

> +       {
> +               /*  CPU Debug UCI data */
> +               .devarch        = 0x47706a15,
> +               .devarch_mask   = 0xfff0ffff,
> +               .devtype        = 0x00000015,
> +       }
> +};