linux-kernel - Re: [PATCH] mtd: rawnand: denali_dt: remove single anonymous clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da2ea926-30e9-c7b9-8b1f-ee65ccc0fb7a@kernel.org>
Date:   Thu, 31 Jan 2019 11:24:16 -0600
From:   Dinh Nguyen <dinguyen@...nel.org>
To:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>
Cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Boris Brezillon <bbrezillon@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Boris Brezillon <boris.brezillon@...tlin.com>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH] mtd: rawnand: denali_dt: remove single anonymous clock
 support



On 1/28/19 4:20 AM, Miquel Raynal wrote:
> Hi Dinh,
> 
> Masahiro Yamada <yamada.masahiro@...ionext.com> wrote on Wed, 16 Jan
> 2019 10:27:11 +0900:
> 
>> (+CC Dinh Nguyen)
>>
>> On Tue, Jan 15, 2019 at 5:22 PM Miquel Raynal <miquel.raynal@...tlin.com> wrote:
>>>
>>> Hi Masahiro,
>>>
>>> Masahiro Yamada <yamada.masahiro@...ionext.com> wrote on Tue, 15 Jan
>>> 2019 17:11:34 +0900:
>>>  
>>>> Commit 6f1fe97bec34 ("mtd: rawnand: denali_dt: add more clocks based
>>>> on IP datasheet") introduced a more correct binding that requires
>>>> three named clocks.
>>>>
>>>> Now that all upstream DT files migrated over to it, remove the single
>>>> anonymous clock support.  
>>>
>>> I would love to do that but I think this is against the "DT backward
>>> compatibility rule".  
>>
>> Yeah, I know this rule, but we break DT binding from time to time.
>>
>>
>>
>>> Anyway, IIRC it is accepted that this kind of
>>> rule might be broken if decided per the arch-maintainer (in this
>>> case, you I suppose). So if this is really what you want, I'll queue
>>> it.  
>>
>> My platform is fine, but this driver is used by SOCFPGA boards as well.
>>
>> I CCed the SOCFPGA maintainer, Dinh Nguyen.
>>
> 
> Gentle ping on this topic.
> 

This patch looks fine to be. Feel free to add:

Tested-by: Dinh Nguyen <dinguyen@...nel.org>

Dinh