linux-kernel - Re: [PATCH] dt-bindings: hwmon: Add lm75 documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190131180619.GA17074@roeck-us.net>
Date:   Thu, 31 Jan 2019 10:06:19 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jagan Teki <jagan@...rulasolutions.com>
Cc:     Jean Delvare <jdelvare@...e.com>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-amarula@...rulasolutions.com
Subject: Re: [PATCH] dt-bindings: hwmon: Add lm75 documentation

On Tue, Jan 29, 2019 at 12:26:23PM +0530, Jagan Teki wrote:
> Add dt-binding documentation for lm75 hwmon sensor.
> 
> Currently documented for national,lm75 and st,stlm75 and
> rest might add when required.

Why ? The various properties are already implemented in the driver.
I don't see the value documenting only two of them.

I do see though that nxp,lm75, and nxp,lm75a are used but _not_
referenced in the driver.

If we start cleaning that up I think it would make more sense
to clean up everything, not just part of it.

Thanks,
Guenter

> 
> Signed-off-by: Jagan Teki <jagan@...rulasolutions.com>
> ---
>  Documentation/devicetree/bindings/hwmon/lm75.txt | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/lm75.txt b/Documentation/devicetree/bindings/hwmon/lm75.txt
> new file mode 100644
> index 000000000000..e384a3765f10
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/lm75.txt
> @@ -0,0 +1,15 @@
> +*LM75 hwmon sensor.
> +
> +Required properties:
> +- compatible: one of
> +	"national,lm75"
> +	"st,stlm75"
> +
> +- reg: I2C address
> +
> +Example:
> +
> +sensor@48 {
> +	compatible = "st,stlm75";
> +	reg = <0x48>;
> +};