[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=V068E_d-RyJdCTm4ycj+oSfe7zC8goGKhKbyELaN63GQ@mail.gmail.com>
Date: Fri, 1 Feb 2019 15:54:50 -0800
From: Doug Anderson <dianders@...omium.org>
To: Bjorn Andersson <bjorn.andersson@...aro.org>
Cc: Andy Gross <andy.gross@...aro.org>,
David Brown <david.brown@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Ohad Ben-Cohen <ohad@...ery.com>,
Arun Kumar Neelakantam <aneela@...eaurora.org>,
Sibi Sankar <sibis@...eaurora.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
devicetree@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
linux-remoteproc@...r.kernel.org
Subject: Re: [PATCH v5 03/10] arm64: dts: sdm845: Introduce ADSP and CDSP PAS nodes
Hi,
On Wed, Jan 30, 2019 at 4:40 PM Bjorn Andersson
<bjorn.andersson@...aro.org> wrote:
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index d19486ba1e5e..07d9cd6fba7d 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -325,6 +325,64 @@
> };
> };
>
> + adsp_pas: remoteproc-adsp {
> + compatible = "qcom,sdm845-adsp-pas";
After discussion with you offline I now understand why this is using
"-pas" and not "-pil".
...and I understand that on my particular board (which should use
"-pil") we'll juse leave this as status = "disabled".
It would be good if something in this series updated the bindings to
make it clearer since I can't find anything in these two files:
Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt
Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
...explain when the "-pil" is used and when the "-pas" is used.
-Doug
Powered by blists - more mailing lists