linux-kernel - Re: [PATCH 0/7] crypto: cleanup debugfs usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 1 Feb 2019 14:48:56 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     David Miller <davem@...emloft.net>, linux-kernel@...r.kernel.org,
        linux-crypto@...r.kernel.org
Subject: Re: [PATCH 0/7] crypto: cleanup debugfs usage

On Tue, Jan 22, 2019 at 04:14:15PM +0100, Greg Kroah-Hartman wrote:
> When calling debugfs code, there is no need to ever check the return
> value of the call, as no logic should ever change if a call works
> properly or not.  Fix up a bunch of crypto-specific code to not care
> about the results of debugfs.
> 
> Greg Kroah-Hartman (7):
>   crypto: qat: no need to check return value of debugfs_create functions
>   crypto: ccrree: no need to check return value of debugfs_create
>     functions
>   crypto: axis: no need to check return value of debugfs_create
>     functions
>   crypto: cavium: zip: no need to check return value of debugfs_create
>     functions
>   crypto: cavium: nitrox: no need to check return value of
>     debugfs_create functions
>   crypto: ccp: no need to check return value of debugfs_create functions
>   crypto: caam: no need to check return value of debugfs_create
>     functions
> 
>  drivers/crypto/axis/artpec6_crypto.c          |  9 ----
>  drivers/crypto/caam/ctrl.c                    | 21 +++-----
>  drivers/crypto/caam/intern.h                  |  1 -
>  drivers/crypto/cavium/nitrox/nitrox_debugfs.c | 27 ++--------
>  drivers/crypto/cavium/nitrox/nitrox_debugfs.h |  5 +-
>  drivers/crypto/cavium/nitrox/nitrox_main.c    |  4 +-
>  drivers/crypto/cavium/zip/zip_main.c          | 52 ++++---------------
>  drivers/crypto/ccp/ccp-debugfs.c              | 36 +++----------
>  drivers/crypto/ccree/cc_debugfs.c             | 22 ++------
>  drivers/crypto/ccree/cc_debugfs.h             |  8 +--
>  drivers/crypto/ccree/cc_driver.c              |  7 +--
>  drivers/crypto/qat/qat_c3xxx/adf_drv.c        |  5 --
>  drivers/crypto/qat/qat_c3xxxvf/adf_drv.c      |  5 --
>  drivers/crypto/qat/qat_c62x/adf_drv.c         |  5 --
>  drivers/crypto/qat/qat_c62xvf/adf_drv.c       |  5 --
>  drivers/crypto/qat/qat_common/adf_cfg.c       |  7 ---
>  drivers/crypto/qat/qat_common/adf_transport.c |  6 ---
>  .../qat/qat_common/adf_transport_debug.c      | 15 ------
>  drivers/crypto/qat/qat_dh895xcc/adf_drv.c     |  5 --
>  drivers/crypto/qat/qat_dh895xccvf/adf_drv.c   |  5 --
>  20 files changed, 38 insertions(+), 212 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt