linux-kernel - Re: [PATCH] crypto4xx: Fix wrong ppc4xx_trng_probe()/ppc4xx_trng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190201064951.ecnljqb4xji57grj@gondor.apana.org.au>
Date:   Fri, 1 Feb 2019 14:49:51 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Corentin Labbe <clabbe@...libre.com>
Cc:     chunkeey@...glemail.com, davem@...emloft.net,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto4xx: Fix wrong
 ppc4xx_trng_probe()/ppc4xx_trng_remove() arguments

On Wed, Jan 23, 2019 at 11:24:18AM +0000, Corentin Labbe wrote:
> When building without CONFIG_HW_RANDOM_PPC4XX, I hit the following build failure:
> drivers/crypto/amcc/crypto4xx_core.c: In function 'crypto4xx_probe':
> drivers/crypto/amcc/crypto4xx_core.c:1407:20: error: passing argument 1 of 'ppc4xx_trng_probe' from incompatible pointer type [-Werror=incompatible-pointer-types]
> In file included from drivers/crypto/amcc/crypto4xx_core.c:50:0:
> drivers/crypto/amcc/crypto4xx_trng.h:28:20: note: expected 'struct crypto4xx_device *' but argument is of type 'struct crypto4xx_core_device *'
> drivers/crypto/amcc/crypto4xx_core.c: In function 'crypto4xx_remove':
> drivers/crypto/amcc/crypto4xx_core.c:1434:21: error: passing argument 1 of 'ppc4xx_trng_remove' from incompatible pointer type [-Werror=incompatible-pointer-types]
> In file included from drivers/crypto/amcc/crypto4xx_core.c:50:0:
> drivers/crypto/amcc/crypto4xx_trng.h:30:20: note: expected 'struct crypto4xx_device *' but argument is of type 'struct crypto4xx_core_device *'
> 
> This patch fix the needed argument of ppc4xx_trng_probe()/ppc4xx_trng_remove() in that case.
> 
> Fixes: 5343e674f32f ("crypto4xx: integrate ppc4xx-rng into crypto4xx")
> Signed-off-by: Corentin Labbe <clabbe@...libre.com>
> ---
>  drivers/crypto/amcc/crypto4xx_trng.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt