[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e47d89e3-9bb0-95b0-db63-717594b1692b@huawei.com>
Date: Fri, 1 Feb 2019 17:13:52 +0800
From: Hanjun Guo <guohanjun@...wei.com>
To: John Garry <john.garry@...wei.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Robin Murphy <robin.murphy@....com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@....com>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Bjorn Helgaas <helgaas@...nel.org>,
Christoph Hellwig <hch@....de>
CC: <linux-usb@...r.kernel.org>, <linux-acpi@...r.kernel.org>,
<linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linuxarm@...wei.com>,
Jonathan Cameron <Jonathan.Cameron@...wei.com>,
<anthony.jebson@...wei.com>, Hanjun Guo <hanjun.guo@...aro.org>
Subject: Re: [RFC PATCH] USB: PCI: set 32bit DMA mask for PCI based USB
controllers
On 2019/2/1 13:55, Hanjun Guo wrote:
> Hi John,
>
> On 2019/1/31 17:54, John Garry wrote:
>> On 30/01/2019 07:01, Hanjun Guo wrote:
>>> From: Hanjun Guo <hanjun.guo@...aro.org>
> [...]
>>>
>>> drivers/usb/core/hcd-pci.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c
>>> index 0343246..a9c33e6 100644
>>> --- a/drivers/usb/core/hcd-pci.c
>>> +++ b/drivers/usb/core/hcd-pci.c
>>> @@ -188,6 +188,10 @@ int usb_hcd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
>>> if (pci_enable_device(dev) < 0)
>>> return -ENODEV;
>>>
>>> + retval = dma_coerce_mask_and_coherent(&dev->dev, DMA_BIT_MASK(32));
>>> + if (retval)
>>> + return retval;
>>
>> Hi Hanjun,
>>
>> You're missing tidy-up upon failure.
>
> Good catch, needs to disable pci for failure, I will send
> a updated version to address the comments from you and Christoph.
There is a _DMA method which was introduced in ACPI 6.2 to cover
this, I will try that solution then report back.
Thanks
Hanjun
Powered by blists - more mailing lists