linux-kernel - Re: [PATCH] HID: intel-ish-hid: Use VID/PID from ISH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAO-hwJJBrA8i=p-LbHJJbyngoht=bBqfzBt3jzQKYjOfsCADUA@mail.gmail.com>
Date:   Fri, 1 Feb 2019 10:46:43 +0100
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc:     Jiri Kosina <jikos@...nel.org>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: intel-ish-hid: Use VID/PID from ISH

On Wed, Jan 30, 2019 at 10:32 PM Srinivas Pandruvada
<srinivas.pandruvada@...ux.intel.com> wrote:
>
> The Intel ISH HID can now have other devices attached to it, not just
> sensors. Hence ISH HID transport is no longer just used for sensors.
> Currently the vendor and product id is hardcoded for sensors, but they
> can be obtained from ISH firmware for the real device. The driver already
> extract them and store as part of device_info structure in client_data.
> So use vendor id/product id obtained from the ISH firmware.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> ---

Applied to for-5.1/ish

Cheers,
Benjamin

>  drivers/hid/intel-ish-hid/ishtp-hid.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.c b/drivers/hid/intel-ish-hid/ishtp-hid.c
> index e918d78e541c..bc4c536f3c0d 100644
> --- a/drivers/hid/intel-ish-hid/ishtp-hid.c
> +++ b/drivers/hid/intel-ish-hid/ishtp-hid.c
> @@ -206,8 +206,8 @@ int ishtp_hid_probe(unsigned int cur_hid_dev,
>         hid->bus = BUS_INTEL_ISHTP;
>         hid->dev.parent = &client_data->cl_device->dev;
>         hid->version = le16_to_cpu(ISH_HID_VERSION);
> -       hid->vendor = le16_to_cpu(ISH_HID_VENDOR);
> -       hid->product = le16_to_cpu(ISH_HID_PRODUCT);
> +       hid->vendor = le16_to_cpu(client_data->hid_devices[cur_hid_dev].vid);
> +       hid->product = le16_to_cpu(client_data->hid_devices[cur_hid_dev].pid);
>         snprintf(hid->name, sizeof(hid->name), "%s %04X:%04X", "hid-ishtp",
>                 hid->vendor, hid->product);
>
> --
> 2.17.2
>