linux-kernel - Re: linux-next: Fixes tags need some work in the drm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKMK7uGf7X3m3Hp1r3-RSrKvGqsJK61WAMQ7goFP_28GAieP2w@mail.gmail.com>
Date:   Fri, 1 Feb 2019 11:05:43 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Dave Airlie <airlied@...ux.ie>,
        DRI <dri-devel@...ts.freedesktop.org>,
        Leo Li <sunpeng.li@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Kent Russell <kent.russell@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Nicholas Kazlauskas <nicholas.kazlauskas@....com>,
        Ken Chalmers <ken.chalmers@....com>
Subject: Re: linux-next: Fixes tags need some work in the drm tree

On Fri, Feb 1, 2019 at 12:57 AM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   a93587b31e34 ("drm/amd/display: Only get the connector state for VRR when toggled")
>
> Fixes tag
>
>   Fixes: 3cc22f281318 ("drm/amdgpu: Set FreeSync state using drm VRR properties")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe instead:
>
>   FIxes: bb47de736661 ("drm/amdgpu: Set FreeSync state using drm VRR properties")
>
> In commit
>
>   32e61361b82e ("drm/amd/display: Fix 64-bit division for 32-bit builds")
>
> Fixes tag
>
>   Fixes: https://lists.freedesktop.org/archives/dri-devel/2018-December/201008.html
>
> has these problem(s):
>
>   - No SHA1 recognised
>
> Maybe instead:
>
>   Fixes: 80604e27bc9 ("drm/amd/display: Use 100 Hz precision for pipe pixel clocks")
>
> In commit
>
>   c4312c27c826 ("drm/amdgpu: Cleanup 2 compiler warnings")
>
> Fixes tag
>
>   Fixes: e4ae0fc drm/amdgpu: implement gfx8 post_soft_reset
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
>
> Fixes tag
>
>   Fixes: 5e01c09 drm/amdgpu/gfx_v8_0: Reorder the gfx, kiq and kcq rings
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe instead:
>
>   Fixes: c6064de4b734 ("drm/amdgpu/gfx_v8_0: Reorder the gfx, kiq and kcq rings test sequence")

Yeah the top 71 commits in the latest amdgpu pull got rebased, which
is a bit much. Where are we with the "direct group commit, no more
rebases" project for amd? Still stuck on CI troubles?

Another one: Is the above checker script available somewhere, could be
useful to put that into our own scripts to make sure this doesn't
happen again.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch