linux-kernel - RE: [PATCH v5] driver: uio: fix possible memory leak in uio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F88C5DDA1E80143B232E89585ACE27D025EBEBB@DGGEMM528-MBX.china.huawei.com>
Date:   Fri, 1 Feb 2019 01:45:14 +0000
From:   "liujian (CE)" <liujian56@...wei.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "xiubli@...hat.com" <xiubli@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v5] driver: uio: fix possible memory leak in uio_open

> -----Original Message-----
> From: Greg KH [mailto:gregkh@...uxfoundation.org]
> Sent: Thursday, January 31, 2019 11:36 PM
> To: liujian (CE) <liujian56@...wei.com>
> Cc: xiubli@...hat.com; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v5] driver: uio: fix possible memory leak in uio_open
> 
> On Wed, Jan 23, 2019 at 06:38:24AM +0800, Liu Jian wrote:
> > If 'idev->info' is NULL, we need to  free 'listener'
> >
> > Fixes: 57c5f4df0a5a ("uio: fix crash after the device is
> > unregistered")
> > Signed-off-by: Liu Jian <liujian56@...wei.com>
> > ---
> > v1->v2:
> > rename the "err_infoopen" to "err_idev_info"
> > v2->3:
> > put the extra info after the "--"
> > v3-v4:
> > add git log
> > v4-v5:
> > correct git log
> >
> >  drivers/uio/uio.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index
> > 1313422..b4ae2d9 100644
> > --- a/drivers/uio/uio.c
> > +++ b/drivers/uio/uio.c
> > @@ -491,18 +491,19 @@ static int uio_open(struct inode *inode, struct
> file *filep)
> >  	if (!idev->info) {
> >  		mutex_unlock(&idev->info_lock);
> >  		ret = -EINVAL;
> > -		goto err_alloc_listener;
> > +		goto err_idev_info;
> >  	}
> >
> >  	if (idev->info && idev->info->open)
> >  		ret = idev->info->open(idev->info, inode);
> >  	mutex_unlock(&idev->info_lock);
> >  	if (ret)
> > -		goto err_infoopen;
> > +		goto err_idev_info;
> >
> >  	return 0;
> >
> > -err_infoopen:
> > +err_idev_info:
> > +	filep->private_data = NULL;
> >  	kfree(listener);
> >
> >  err_alloc_listener:
> > --
> > 2.7.4
> >
> 
> This does not apply to my tree at all :(

I am sorry to have sent so many versions, during which this issue has been resolved by commit 1e09cdd506c8833a9d52cb61009798660cff4051.
So please ignore this patch , and thank you and Xiubo Li in this patch~

> Please rebase it against the char-misc-next branch of my char-misc.git
> tree and resend.
> 
> thanks,
> 
> greg k-h