linux-kernel - [PATCH] befs: Removed incorrect check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20190201134801.19436-1-axeld@pinc-software.de>
Date:   Fri,  1 Feb 2019 14:48:01 +0100
From:   Axel Dörfler <axeld@...c-software.de>
To:     Luis de Bethencourt <luisbg@...nel.org>,
        Salah Triki <salah.triki@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     Axel Dörfler <axeld@...c-software.de>
Subject: [PATCH] befs: Removed incorrect check

The relation between ag_shift and blocks_per_ag is a bit more complex,
and also depends on the fs block size.
Since blocks_per_ag is not even being used, simply omit the check.

Signed-off-by: Axel Dörfler <axeld@...c-software.de>
---
 fs/befs/super.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/fs/befs/super.c b/fs/befs/super.c
index 7c50025c9..29fa37557 100644
--- a/fs/befs/super.c
+++ b/fs/befs/super.c
@@ -99,13 +99,6 @@ befs_check_sb(struct super_block *sb)
 		return BEFS_ERR;
 	}
 
-
-	/* ag_shift also encodes the same information as blocks_per_ag in a
-	 * different way, non-fatal consistency check
-	 */
-	if ((1 << befs_sb->ag_shift) != befs_sb->blocks_per_ag)
-		befs_error(sb, "ag_shift disagrees with blocks_per_ag.");
-
 	if (befs_sb->log_start != befs_sb->log_end ||
 	    befs_sb->flags == BEFS_DIRTY) {
 		befs_error(sb, "Filesystem not clean! There are blocks in the "
-- 
2.17.1