linux-kernel - Re: linux-next: Fixes tags needs some work in the akpm-current tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190201001825.GB3110@bart.dudau.co.uk>
Date:   Fri, 1 Feb 2019 00:18:26 +0000
From:   Liviu Dudau <liviu@...au.co.uk>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Qian Cai <cai@....pw>, Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Fixes tags needs some work in the akpm-current tree

On Thu, Jan 31, 2019 at 02:57:34PM -0800, Andrew Morton wrote:
> On Thu, 31 Jan 2019 22:51:52 +0000 Liviu Dudau <liviu@...au.co.uk> wrote:
> 
> > On Wed, Jan 30, 2019 at 08:51:42PM -0500, Qian Cai wrote:
> > > 
> > > 
> > > On 1/30/19 7:05 PM, Stephen Rothwell wrote:
> > > > In commit
> > > > 
> > > >   6e9ed490d190 ("mm/page_owner: fix for deferred struct page init")
> > > > 
> > > > Fixes tag
> > > > 
> > > >   Fixes: fe53ca54270 ("mm: use early_pfn_to_nid in page_ext_init")
> > > > 
> > > > has these problem(s):
> > > > 
> > > >   - SHA1 should be at least 12 digits long
> > > >     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > > >     or later) just making sure it is not set (or set to "auto").
> > > > 
> > > 
> > > I think it is better to replace with this version instead,
> > > 
> > > https://lore.kernel.org/lkml/20190115202812.75820-1-cai@lca.pw/
> > 
> > 
> > That patch does not look related, afaict.
> 
> Confused.
> 
> https://lore.kernel.org/lkml/20190115202812.75820-1-cai@lca.pw/
> and
> https://lore.kernel.org/lkml/20181220203156.43441-1-cai@lca.pw/T/#u
> 
> are very much related?

My bad, I've read the top of the message that was talking about my commit splitting the
Fixes: commit title into multiple lines and assumed that was the only issue reported.


> 
> > Andrew, do you want me to re-send the patch with a fixed commit log, or are you OK to
> > do some inline editing?
> 
> Resend what, exactly?

Content of commit 86c7502b25ed so that the title of the commit it fixes does not spill
over into the next line.

Best regards,
Liviu


-- 
           ________________________________________________________
  ________|                                                        |_______
  \       |  With enough courage, you can do without a reputation  |      /
   \      |                                  -- Rhett Butler       |     /
   /      |________________________________________________________|     \
  /__________)                                                  (_________\