linux-kernel - RE: [PATCH v2] nfit: add Hyper-V NVDIMM DSM command set to white list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PU1P153MB0169977604493B82B662A01CBF920@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
Date:   Fri, 1 Feb 2019 17:14:10 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     Dan Williams <dan.j.williams@...el.com>
CC:     Ross Zwisler <zwisler@...nel.org>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Dave Jiang <dave.jiang@...el.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        Josh Poulson <jopoulso@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "driverdev-devel@...uxdriverproject.org" 
        <driverdev-devel@...uxdriverproject.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Michael Kelley <mikelley@...rosoft.com>,
        Sasha Levin <Alexander.Levin@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>
Subject: RE: [PATCH v2] nfit: add Hyper-V NVDIMM DSM command set to white list

> From: Dan Williams <dan.j.williams@...el.com>
> Sent: Tuesday, January 29, 2019 10:24 PM
> On Mon, Jan 28, 2019 at 4:56 PM Dexuan Cui <decui@...rosoft.com> wrote:
> >
> >
> > Add the Hyper-V _DSM command set to the white list of NVDIMM command
> > sets.
> >
> > Thanks Dan Williams <dan.j.williams@...el.com> for writing the
> > comment change.
> > ---
> > Changes in v2:
> >     Updated the comment and changelog (Thanks, Dan!)
> >     Rebased to the tag libnvdimm-fixes-5.0-rc4 of the nvdimm tree.
> 
> Thanks for the re-spin, applied.

Hi Dan,
Unluckily it looks this commit causes a regression on 
https://git.kernel.org/pub/scm/linux/kernel/git/djbw/nvdimm.git/log/?h=libnvdimm-pending

With the patch, "ndctl list" shows nothing, and /dev/pmem0 can't appear.
If I revert the patch, it will be back to normal.

I attached the config/logs. In the bad case, "dmesg" shows a line
[    5.259017] nd_pmem namespace0.0: 0x0000000000000000, too small must be at least 0x1000

Any idea why this happens? I'm digging into the details and I appreciate your insights.

BTW, the patch does work fine linux-next's next-20190107.

Thanks,
-- Dexuan

View attachment "dmesg.bad.txt" of type "text/plain" (48646 bytes)

View attachment "dmesg.good.txt" of type "text/plain" (45986 bytes)

View attachment "kernel.config.txt" of type "text/plain" (93837 bytes)

View attachment "bad.ndctl.list.vvv.txt" of type "text/plain" (1965 bytes)