linux-kernel - Re: [PATCH v9 6/6] tpm: pass an array of tpm_extend_digest structures to tpm_pcr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190201174256.GA23559@linux.intel.com>
Date:   Fri, 1 Feb 2019 19:42:56 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Mimi Zohar <zohar@...ux.ibm.com>, christophe.ricard@...il.com
Cc:     Roberto Sassu <roberto.sassu@...wei.com>, david.safford@...com,
        monty.wiseman@...com, matthewgarrett@...gle.com,
        linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, keyrings@...r.kernel.org,
        linux-kernel@...r.kernel.org, silviu.vlasceanu@...wei.com
Subject: Re: [PATCH v9 6/6] tpm: pass an array of tpm_extend_digest
 structures to tpm_pcr_extend()

On Fri, Feb 01, 2019 at 07:33:30PM +0200, Jarkko Sakkinen wrote:
> On Fri, Feb 01, 2019 at 09:33:09AM -0500, Mimi Zohar wrote:
> > Thanks!  I just finished compiling, rebooting, and verifying the IMA
> > boot-aggregate matches.
> > 
> > While compiling, I saw some messages that "TPM_BUFSIZE is redefined"
> > for tpm_i2c_infineon, tpm_i2c_nuvoton, and st33zp24.  Didn't look to
> > see if this is a result of this patch set or not.
> > 
> > The IMA boot-aggregate matches the PCRs.
> > 
> > Tested-by: Mimi Zohar <zohar@...ux.ibm.com> (on x86 for TPM 1.2 & PTT
> > TPM 2.0)
> 
> Thank you.
> 
> I found the reason for that warning. It is redefined, for reason unknown
> to me in drivers/char/tpm/st33zp24/st33zp24.h (commit bf38b8710892).
> 
> I'll post a fix to that commit ASAP. After that commit has been applied
> I can apply Roberto's patches.

Just sent. No need to any testing for that one. Just need one
reviewed-by or even acked-by, and after that I will apply all Roberto's
patches.

/Jarkko