linux-kernel - Re: [PATCH v2 1/2] staging: iio: ad7780: add gain & filter gpio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190201175514.7kerqvuln4mrhinp@renatolg>
Date:   Fri, 1 Feb 2019 15:55:16 -0200
From:   Renato Lui Geh <renatogeh@...il.com>
To:     "Popa, Stefan Serban" <StefanSerban.Popa@...log.com>
Cc:     "renatogeh@...il.com" <renatogeh@...il.com>,
        "kernel-usp@...glegroups.com" <kernel-usp@...glegroups.com>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>,
        "knaack.h@....de" <knaack.h@....de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "giuliano.belinassi@....br" <giuliano.belinassi@....br>,
        "pmeerw@...erw.net" <pmeerw@...erw.net>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2 1/2] staging: iio: ad7780: add gain & filter gpio
 support

On 02/01, Popa, Stefan Serban wrote:
>
>Adding support for gpios, normally doesn't have anything to do with
>the information stored in the iio_chan_spec struct.
>Also, we need to try to work with the already defined attributes. In your
>case, setting the gain GPIO is equivalent to modifying the scale, while
>setting the filter GPIO results in a change in sampling frequency.
>Therefore, we need use a macro which has the IIO_CHAN_INFO_SCALE and
>IIO_CHAN_INFO_FREQUENCY flags set. I think AD_SD_CHANNEL should do just
>fine.
>I hope this answers your question.
>-Stefan

It does. Thank you. :)