linux-kernel - RE: [PATCH v6 3/3] drivers: soc: xilinx: Add ZynqMP PM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR02MB5992A4D0347DF535569DBC4EB8920@BYAPR02MB5992.namprd02.prod.outlook.com>
Date:   Fri, 1 Feb 2019 18:44:36 +0000
From:   Jolly Shah <JOLLYS@...inx.com>
To:     Sudeep Holla <sudeep.holla@....com>
CC:     "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "andy.gross@...aro.org" <andy.gross@...aro.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "geert+renesas@...der.be" <geert+renesas@...der.be>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "sean.wang@...iatek.com" <sean.wang@...iatek.com>,
        "m.szyprowski@...sung.com" <m.szyprowski@...sung.com>,
        Michal Simek <michals@...inx.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        Rajan Vaja <RAJANV@...inx.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v6 3/3] drivers: soc: xilinx: Add ZynqMP PM driver

Hi Sudeep,

> -----Original Message-----
> From: Sudeep Holla <sudeep.holla@....com>
> Sent: Friday, February 01, 2019 4:15 AM
> To: Jolly Shah <JOLLYS@...inx.com>
> Cc: matthias.bgg@...il.com; andy.gross@...aro.org; shawnguo@...nel.org;
> geert+renesas@...der.be; bjorn.andersson@...aro.org;
> sean.wang@...iatek.com; m.szyprowski@...sung.com; Michal Simek
> <michals@...inx.com>; robh+dt@...nel.org; mark.rutland@....com; Rajan
> Vaja <RAJANV@...inx.com>; devicetree@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v6 3/3] drivers: soc: xilinx: Add ZynqMP PM driver
> 
> On Thu, Jan 31, 2019 at 07:01:05PM +0000, Jolly Shah wrote:
> > >
> > > NACK, if this is for system suspend/reset ? You can just use exiting
> > > sysfs, no need to create Xilinx specific new ones. Moreover you need to
> > > use PSCI to make sure higher ELs can do orderly suspend/shutdown.
> > >
> >
> > We have power off suspend mode which is not supported by existing sysfs and
> > hence new one is needed. Suspend is handled through PSCI interface only.
> >
> 
> I see only 2 cases supported SUSPEND_SYSTEM_SHUTDOWN and
> SUSPEND_POWER_REQUEST. Both are already support so my NACK still stands.

The 2 cases(SUSPEND_SYSTEM_SHUTDOWN and  SUSPEND_POWER_REQUEST )in isr is for remote suspend.  Sysfs is for self suspend and it supports PM_SUSPEND_MODE_STD and PM_SUSPEND_MODE_POWER_OFF(power off suspend).

Thanks,
Jolly Shah

> 
> --
> Regards,
> Sudeep