linux-kernel - Re: [PATCH v3 08/13] spi: atmel-quadspi: drop unused and NOP transfer macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 2 Feb 2019 08:46:38 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <bbrezillon@...nel.org>
CC:     <broonie@...nel.org>, <robh+dt@...nel.org>, <mark.rutland@....com>,
        <Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <Ludovic.Desroches@...rochip.com>, <Cyrille.Pitchen@...rochip.com>,
        <bugalski.piotr@...il.com>, <linux-spi@...r.kernel.org>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-mtd@...ts.infradead.org>
Subject: Re: [PATCH v3 08/13] spi: atmel-quadspi: drop unused and NOP transfer
 macros



On 02/02/2019 09:13 AM, Boris Brezillon wrote:
> On Sat, 2 Feb 2019 04:07:33 +0000
> <Tudor.Ambarus@...rochip.com> wrote:
> 
>> From: Tudor Ambarus <tudor.ambarus@...rochip.com>
>>
>> Remove NOP when setting read transfer type. Remove useless
>> setting of write transfer type when
>> op->data.dir == SPI_MEM_DATA_IN && !op->data.nbytes.
>>
>> QSPI_IFR_TFRTYP_TRSFR_WRITE is specific just to sama5d2 qspi,
>> rename it to QSPI_IFR_SAMA5D2_WRITE_TRSFR.
>>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@...rochip.com>
>> ---
>> v3: new patch
>>
>>  drivers/spi/atmel-quadspi.c | 12 +++---------
>>  1 file changed, 3 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
>> index d26d4cd0e36b..bfa5f5e92d96 100644
>> --- a/drivers/spi/atmel-quadspi.c
>> +++ b/drivers/spi/atmel-quadspi.c
>> @@ -113,11 +113,7 @@
>>  #define QSPI_IFR_OPTL_4BIT              (2 << 8)
>>  #define QSPI_IFR_OPTL_8BIT              (3 << 8)
>>  #define QSPI_IFR_ADDRL                  BIT(10)
>> -#define QSPI_IFR_TFRTYP_MASK            GENMASK(13, 12)
>> -#define QSPI_IFR_TFRTYP_TRSFR_READ      (0 << 12)
>> -#define QSPI_IFR_TFRTYP_TRSFR_READ_MEM  (1 << 12)
>> -#define QSPI_IFR_TFRTYP_TRSFR_WRITE     (2 << 12)
>> -#define QSPI_IFR_TFRTYP_TRSFR_WRITE_MEM (3 << 13)
>> +#define QSPI_IFR_SAMA5D2_WRITE_TRSFR	BIT(13)
> 
> Can you define QSPI_IFR_TFRTYP_MEM (bit 12) even if it's not used yet?

Shouldn't be introduced with the dir map support?