linux-kernel - Re: [PATCH] staging:iio:ad7152: align line to match open parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 2 Feb 2019 09:56:47 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Camylla Cantanheide <c.cantanheide@...il.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, kernel-usp@...glegroups.com,
        Feulo <guifeulo@...il.com>
Subject: Re: [PATCH] staging:iio:ad7152: align line to match open
 parenthesis

On Tue, 29 Jan 2019 16:31:00 -0200
Camylla Cantanheide <c.cantanheide@...il.com> wrote:

> From: Feulo <guifeulo@...il.com>
> 
> Align broken line to match upper line parenthesis. Solves the
> checkpatch.pl's message
> 
> CHECK: Alignment should match open parenthesis.
> 
> Signed-off-by: Feulo <guifeulo@...il.com>
For reference should be full name (though I'm obviously making
assumptions).

Also, this is very unlucky timing as I have a patch sent on 
Wednesday to drop this driver on the basis the part is going away
and we don't know of anyone who actually has hardware.
Given I'm going to apply that in a moment, adding this one would
just be noise.

Sorry.  This happens sometimes in the churn of the kernel!

Jonathan


> Signed-off-by: Camylla Cantanheide <c.cantanheide@...il.com>
> ---
>  drivers/staging/iio/cdc/ad7152.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
> index 25f51db..e7f082f 100644
> --- a/drivers/staging/iio/cdc/ad7152.c
> +++ b/drivers/staging/iio/cdc/ad7152.c
> @@ -362,7 +362,7 @@ static int ad7152_read_raw(struct iio_dev *indio_dev,
>  		/* Trigger a single read */
>  		regval |= AD7152_CONF_MODE_SINGLE_CONV;
>  		ret = i2c_smbus_write_byte_data(chip->client, AD7152_REG_CFG,
> -				regval);
> +						regval);
>  		if (ret < 0)
>  			goto out;
>