linux-kernel - Re: [PATCH AUTOSEL 4.19 083/258] drm: Move drm_mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 2 Feb 2019 12:32:16 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Sean Paul <sean@...rly.run>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Sean Paul <seanpaul@...omium.org>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH AUTOSEL 4.19 083/258] drm: Move drm_mode_setcrtc() local
 re-init to failure path

On Mon, Jan 28, 2019 at 04:03:41PM -0500, Sean Paul wrote:
>On Mon, Jan 28, 2019 at 10:56:29AM -0500, Sasha Levin wrote:
>> From: Sean Paul <seanpaul@...omium.org>
>>
>> [ Upstream commit c232e9f41b136c141df9938024e521191a7b910d ]
>>
>> Instead of always re-initializing the variables we need to clean up on
>> out, move the re-initialization into the branch that goes back to retry
>> label.
>>
>> This is a lateral move right now, but will allow us to pull out the
>> modeset locking into common code. I kept this change separate to make
>> things easier to review.
>>
>> Changes in v2:
>> - None
>>
>> Reviewed-by: Daniel Vetter <daniel@...ll.ch>
>> Signed-off-by: Sean Paul <seanpaul@...omium.org>
>> Link: https://patchwork.freedesktop.org/patch/msgid/20181129150423.239081-2-sean@poorly.run
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>
>This probably doesn't need to get pulled back to stable. It was a pre-cursor for
>some new helper macros that also don't need to be pulled back.
>
>(Same comment for the 4.20 version)

Now dropped, thank you.

--
Thanks,
Sasha