linux-kernel - Re: [PATCH][next] media: staging: intel-ipu3: fix unsigned comparison with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 2 Feb 2019 22:12:41 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] media: staging: intel-ipu3: fix unsigned comparison
 with < 0

ping?

On 22/12/2018 11:49, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The comparison css->pipes[pipe].bindex < 0 is always false because
> bindex is an unsigned int.  Fix this by using a signed integer for
> the comparison.
> 
> Detected by CoverityScan, CID#1476023 ("Unsigned compared against 0")
> 
> Fixes: f5f2e4273518 ("media: staging/intel-ipu3: Add css pipeline programming")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/staging/media/ipu3/ipu3-css.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/media/ipu3/ipu3-css.c b/drivers/staging/media/ipu3/ipu3-css.c
> index 44c55639389a..b9354d2bb692 100644
> --- a/drivers/staging/media/ipu3/ipu3-css.c
> +++ b/drivers/staging/media/ipu3/ipu3-css.c
> @@ -1751,7 +1751,7 @@ int ipu3_css_fmt_try(struct ipu3_css *css,
>  					&q[IPU3_CSS_QUEUE_OUT].fmt.mpix;
>  	struct v4l2_pix_format_mplane *const vf =
>  					&q[IPU3_CSS_QUEUE_VF].fmt.mpix;
> -	int i, s;
> +	int i, s, ret;
>  
>  	/* Adjust all formats, get statistics buffer sizes and formats */
>  	for (i = 0; i < IPU3_CSS_QUEUES; i++) {
> @@ -1826,12 +1826,12 @@ int ipu3_css_fmt_try(struct ipu3_css *css,
>  	s = (bds->height - gdc->height) / 2 - FILTER_SIZE;
>  	env->height = s < MIN_ENVELOPE ? MIN_ENVELOPE : s;
>  
> -	css->pipes[pipe].bindex =
> -		ipu3_css_find_binary(css, pipe, q, r);
> -	if (css->pipes[pipe].bindex < 0) {
> +	ret = ipu3_css_find_binary(css, pipe, q, r);
> +	if (ret < 0) {
>  		dev_err(css->dev, "failed to find suitable binary\n");
>  		return -EINVAL;
>  	}
> +	css->pipes[pipe].bindex = ret;
>  
>  	dev_dbg(css->dev, "Binary index %d for pipe %d found.",
>  		css->pipes[pipe].bindex, pipe);
>