linux-kernel - Re: Frequent dwc3 crashes on suspend or reboot since 5.0-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 2 Feb 2019 01:31:05 +0000
From:   Thinh Nguyen <thinh.nguyen@...opsys.com>
To:     John Stultz <john.stultz@...aro.org>,
        Thinh Nguyen <thinh.nguyen@...opsys.com>
CC:     Felipe Balbi <balbi@...nel.org>,
        Zeng Tao <prime.zeng@...ilicon.com>,
        "Jack Pham" <jackp@...eaurora.org>, Chen Yu <chenyu56@...wei.com>,
        lkml <linux-kernel@...r.kernel.org>,
        Linux USB List <linux-usb@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: Frequent dwc3 crashes on suspend or reboot since 5.0-rc1

John Stultz wrote:
> On Fri, Feb 1, 2019 at 4:46 PM Thinh Nguyen <thinh.nguyen@...opsys.com> wrote:
>> John Stultz wrote:
>>> On Fri, Feb 1, 2019 at 4:18 PM John Stultz <john.stultz@...aro.org> wrote:
>>> Bisecting the changes down, it seems like its due to commit
>>> fec9095bdef4e ("usb: dwc3: gadget: remove wait_end_transfer").
>>>
>>> It doesn't happen all the time, so I'll need to run some more testing,
>>> but so far I've not been able to trigger it backing out the patches to
>>> that point.
>> Yeah, it sounds like the same issue. You can review the discussion here:
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.spinics.net_lists_linux-2Dusb_msg176110.html&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=u9FYoxKtyhjrGFcyixFYqTjw1ZX0VsG2d8FCmzkTY-w&m=NafAczsBrlszpsknN68eiuJOr8zYyB34O0R9NCF3-pc&s=ExaEPcrEUReFA79ZWRHG9MELb9eead_QxKiTu1ea8Eg&e=
> Unfortunately, merging in
> https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_pub_scm_linux_kernel_git_balbi_usb.git&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=u9FYoxKtyhjrGFcyixFYqTjw1ZX0VsG2d8FCmzkTY-w&m=NafAczsBrlszpsknN68eiuJOr8zYyB34O0R9NCF3-pc&s=VLaXOrfcXp-6oljE2fC9rBEsPfYTZ6CxKqiQOhW_QKE&e=
> testing/next seems to trigger a different issue:
>
> [   38.585141] OOM killer enabled.
> [   38.585143] Restarting tasks ...
> [   38.585874] ------------[ cut here ]------------
> [   38.585882] ep1out: request 0000000000000000 already in flight
> [   38.585944] WARNING: CPU: 7 PID: 2545 at
> drivers/usb/dwc3/gadget.c:1430 dwc3_gadget_ep_queue+0x1d4/0x200
> [   38.585946] Modules linked in:
> [   38.585960] CPU: 7 PID: 2545 Comm: adbd Tainted: G S
> 5.0.0-rc4-00110-gad0e691 #509
> [   38.585963] Hardware name: HiKey960 (DT)
> [   38.585968] pstate: 80400085 (Nzcv daIf +PAN -UAO)
> [   38.585972] pc : dwc3_gadget_ep_queue+0x1d4/0x200
> [   38.585976] lr : dwc3_gadget_ep_queue+0x1d4/0x200
> [   38.585978] sp : ffffff80149fbb40

It looks like the gadget driver tried to queue request twice.

> Let me know if you have other ideas to try!
>
>

Try to revert this patches series (3 patches) from Felipe testing/next
to see if that helps:
https://patchwork.kernel.org/patch/10764297/

Thinh