linux-kernel - Re: [PATCH -next 1/2] genirq: export irq_chip_set_wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190203130533.072b235e@why.wild-wind.fr.eu.org>
Date:   Sun, 3 Feb 2019 13:05:33 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Brian Masney <masneyb@...tation.org>
Cc:     linus.walleij@...aro.org, tglx@...utronix.de,
        andy.gross@...aro.org, sboyd@...nel.org,
        kernel-build-reports@...ts.linaro.org,
        linaro-kernel@...ts.linaro.org, linux-next@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        bjorn.andersson@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next 1/2] genirq: export irq_chip_set_wake_parent
 symbol

On Sun,  3 Feb 2019 07:31:30 -0500
Brian Masney <masneyb@...tation.org> wrote:

Hi Brian,

> Export the irq_chip_set_wake_parent symbol so that drivers with
> hierarchical IRQ chips can be built as a module.
> 
> This fixes a build failure in linux-next's spmi-gpio when using
> allmodconfig.

I don't think the mention of linux-next helps in the commit message. It
would have been better together with the note below.

> 
> Signed-off-by: Brian Masney <masneyb@...tation.org>
> Reported-by: Mark Brown <broonie@...nel.org>

Otherwise:

Acked-by: Marc Zyngier <marc.zyngier@....com>

Thanks,

	M.

> ---
> See https://www.spinics.net/lists/linux-next/msg46362.html for Mark's
> message.
> 
>  kernel/irq/chip.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index 34e969069488..086d5a34b5a0 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -1381,6 +1381,7 @@ int irq_chip_set_wake_parent(struct irq_data *data, unsigned int on)
>  
>  	return -ENOSYS;
>  }
> +EXPORT_SYMBOL_GPL(irq_chip_set_wake_parent);
>  #endif
>  
>  /**



-- 
Without deviation from the norm, progress is not possible.