lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 03 Feb 2019 14:45:08 +0100 From: Ben Hutchings <ben@...adent.org.uk> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org CC: akpm@...ux-foundation.org, Denis Kirjanov <kda@...ux-powerpc.org>, "YueHaibing" <yuehaibing@...wei.com>, "Al Viro" <viro@...iv.linux.org.uk> Subject: [PATCH 3.16 181/305] sysv: return 'err' instead of 0 in __sysv_write_inode 3.16.63-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: YueHaibing <yuehaibing@...wei.com> commit c4b7d1ba7d263b74bb72e9325262a67139605cde upstream. Fixes gcc '-Wunused-but-set-variable' warning: fs/sysv/inode.c: In function '__sysv_write_inode': fs/sysv/inode.c:239:6: warning: variable 'err' set but not used [-Wunused-but-set-variable] __sysv_write_inode should return 'err' instead of 0 Fixes: 05459ca81ac3 ("repair sysv_write_inode(), switch sysv to simple_fsync()") Signed-off-by: YueHaibing <yuehaibing@...wei.com> Signed-off-by: Al Viro <viro@...iv.linux.org.uk> Signed-off-by: Ben Hutchings <ben@...adent.org.uk> --- fs/sysv/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/sysv/inode.c +++ b/fs/sysv/inode.c @@ -275,7 +275,7 @@ static int __sysv_write_inode(struct ino } } brelse(bh); - return 0; + return err; } int sysv_write_inode(struct inode *inode, struct writeback_control *wbc)
Powered by blists - more mailing lists