linux-kernel - Re: [PATCH] media: videobuf2: Return error after allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 03 Feb 2019 16:54:59 -0500
From:   Nicolas Dufresne <nicolas@...fresne.ca>
To:     Souptick Joarder <jrdr.linux@...il.com>, pawel@...iak.com,
        m.szyprowski@...sung.com, kyungmin.park@...sung.com,
        mchehab@...nel.org
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        sabyasachi.linux@...il.com, brajeswar.linux@...il.com
Subject: Re: [PATCH] media: videobuf2: Return error after allocation failure

Le dimanche 03 février 2019 à 19:06 +0530, Souptick Joarder a écrit :
> There is no point to continuing assignemnt after memory allocation

assignemnt -> assignment.

> failed, rather throw error immediately.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> ---
>  drivers/media/common/videobuf2/videobuf2-vmalloc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/common/videobuf2/videobuf2-vmalloc.c b/drivers/media/common/videobuf2/videobuf2-vmalloc.c
> index 6dfbd5b..d3f71e2 100644
> --- a/drivers/media/common/videobuf2/videobuf2-vmalloc.c
> +++ b/drivers/media/common/videobuf2/videobuf2-vmalloc.c
> @@ -46,16 +46,16 @@ static void *vb2_vmalloc_alloc(struct device *dev, unsigned long attrs,
>  
>  	buf->size = size;
>  	buf->vaddr = vmalloc_user(buf->size);
> -	buf->dma_dir = dma_dir;
> -	buf->handler.refcount = &buf->refcount;
> -	buf->handler.put = vb2_vmalloc_put;
> -	buf->handler.arg = buf;
>  
>  	if (!buf->vaddr) {
>  		pr_debug("vmalloc of size %ld failed\n", buf->size);
>  		kfree(buf);
>  		return ERR_PTR(-ENOMEM);
>  	}
> +	buf->dma_dir = dma_dir;
> +	buf->handler.refcount = &buf->refcount;
> +	buf->handler.put = vb2_vmalloc_put;
> +	buf->handler.arg = buf;
>  
>  	refcount_set(&buf->refcount, 1);
>  	return buf;