linux-kernel - Re: [PATCH ghak105 V3] audit: remove audit_context when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhTmwh-HRiY1+iinhMrqL8xX+3gvu+2ZywEvijDxAf+P-w@mail.gmail.com>
Date:   Sun, 3 Feb 2019 17:53:28 -0500
From:   Paul Moore <paul@...l-moore.com>
To:     Richard Guy Briggs <rgb@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linux-Audit Mailing List <linux-audit@...hat.com>,
        Eric Paris <eparis@...hat.com>, Steve Grubb <sgrubb@...hat.com>
Subject: Re: [PATCH ghak105 V3] audit: remove audit_context when CONFIG_ AUDIT
 and not AUDITSYSCALL

On Fri, Feb 1, 2019 at 10:45 PM Richard Guy Briggs <rgb@...hat.com> wrote:
>
> Remove audit_context from struct task_struct and struct audit_buffer
> when CONFIG_AUDIT is enabled but CONFIG_AUDITSYSCALL is not.
>
> Also, audit_log_name() (and supporting inode and fcaps functions) should
> have been put back in auditsc.c when soft and hard link logging was
> normalized since it is only used by syscall auditing.
>
> See github issue https://github.com/linux-audit/audit-kernel/issues/105
>
> Signed-off-by: Richard Guy Briggs <rgb@...hat.com>
> ---
> Tested with CONFIG_AUDITSYSCALL automatically set "y" and manually set
> "n".  Passes all audit-testsuite with the former and the expected subset
> that don't depend on syscall auditing for the latter.
>
> changelog v2:
> - guard audit_context by CONFIG_AUDITSYSCALL in task_struct
> - rebase/resolve merge conflicts on upstreamed ghak103 v1.1/1
>
> changelog v3:
> - re-instate audit_context in audit_buffer (though not needed)
> - rebase/resolve merge conflicts on upstreamed ghak100 v2.2/2
>
>  include/linux/sched.h |   4 +-
>  kernel/audit.c        | 157 -------------------------------------------------
>  kernel/audit.h        |   9 ---
>  kernel/auditsc.c      | 158 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 161 insertions(+), 167 deletions(-)

Merged into audit/next, thanks.

-- 
paul moore
www.paul-moore.com