linux-kernel - Re: [PATCH 14/35] ARM: davinci: aintc: use the new irqchip config structure in dm* SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96ce8a1e-0b51-7cf0-0cb9-f0f6ae1e563d@lechnology.com>
Date:   Mon, 4 Feb 2019 17:09:37 -0600
From:   David Lechner <david@...hnology.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>, Sekhar Nori <nsekhar@...com>,
        Kevin Hilman <khilman@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 14/35] ARM: davinci: aintc: use the new irqchip config
 structure in dm* SoCs

On 1/31/19 7:39 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> Add the new-style config structures for dm* SoCs. They will be used
> once we make the aintc driver stop using davinci_soc_info.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> ---
>   arch/arm/mach-davinci/dm355.c  | 11 +++++++++++
>   arch/arm/mach-davinci/dm365.c  | 11 +++++++++++
>   arch/arm/mach-davinci/dm644x.c | 11 +++++++++++
>   arch/arm/mach-davinci/dm646x.c | 11 +++++++++++
>   4 files changed, 44 insertions(+)
> 
> diff --git a/arch/arm/mach-davinci/dm355.c b/arch/arm/mach-davinci/dm355.c
> index cf574956ce1d..0dcfcbec522a 100644
> --- a/arch/arm/mach-davinci/dm355.c
> +++ b/arch/arm/mach-davinci/dm355.c
> @@ -15,6 +15,7 @@
>   #include <linux/dma-mapping.h>
>   #include <linux/dmaengine.h>
>   #include <linux/init.h>
> +#include <linux/irqchip/irq-davinci-aintc.h>
>   #include <linux/platform_data/edma.h>
>   #include <linux/platform_data/gpio-davinci.h>
>   #include <linux/platform_data/spi-davinci.h>
> @@ -738,6 +739,16 @@ int __init dm355_init_video(struct vpfe_config *vpfe_cfg,
>   	return 0;
>   }
>   
> +static const struct davinci_aintc_config dm355_aintc_config = {
> +	.reg = {
> +		.start		= DAVINCI_ARM_INTC_BASE,
> +		.end		= DAVINCI_ARM_INTC_BASE + SZ_4K,

missing a minus 1 after SZ_4K?

+		.end		= DAVINCI_ARM_INTC_BASE + SZ_4K - 1,

(repeated 3 more times below)

> +		.flags		= IORESOURCE_MEM,
> +	},
> +	.num_irqs		= 64,
> +	.prios			= dm355_aintc_prios,
> +};
> +
>   void __init dm355_init_irqs(void)
>   {
>   	davinci_aintc_init();