linux-kernel - Re: [PATCH] MIPS: Remove function size check in get_frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 4 Feb 2019 23:16:41 +0000
From:   Paul Burton <paul.burton@...s.com>
To:     Jun-Ru Chang <jrjang@...ltek.com>
CC:     "ralf@...ux-mips.org" <ralf@...ux-mips.org>,
        Paul Burton <pburton@...ecomp.com>,
        "jhogan@...nel.org" <jhogan@...nel.org>,
        Maciej X Rozycki <maciej.rozycki@...s.com>,
        "yamada.masahiro@...ionext.com" <yamada.masahiro@...ionext.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...nel.org" <mingo@...nel.org>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tonywu@...ltek.com" <tonywu@...ltek.com>,
        "jrjang@...ltek.com" <jrjang@...ltek.com>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>
Subject: Re: [PATCH] MIPS: Remove function size check in get_frame_info()

Hello,

Jun-Ru Chang wrote:
> Patch (b6c7a324df37b "MIPS: Fix get_frame_info() handling of
> microMIPS function size.") introduces additional function size
> check for microMIPS by only checking insn between ip and ip + func_size.
> However, func_size in get_frame_info() is always 0 if KALLSYMS is not
> enabled. This causes get_frame_info() to return immediately without
> calculating correct frame_size, which in turn causes "Can't analyze
> schedule() prologue" warning messages at boot time.
> 
> This patch removes func_size check, and let the frame_size check run
> up to 128 insns for both MIPS and microMIPS.
> 
> Signed-off-by: Jun-Ru Chang <jrjang@...ltek.com>
> Signed-off-by: Tony Wu <tonywu@...ltek.com>
> Fixes: b6c7a324df37b ("MIPS: Fix get_frame_info() handling of microMIPS function size.")

Applied to mips-fixes.

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.burton@...s.com to report it. ]