linux-kernel - Re: [PATCH] firmware: hardcode the debug message for -ENOENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Feb 2019 15:30:47 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     yuankuiz@...eaurora.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: hardcode the debug message for -ENOENT

On Mon, Jan 14, 2019 at 05:58:30PM +0800, yuankuiz@...eaurora.org wrote:
> Hi,
> 
>     Refined at below.
> 
> From bbd0d9c8f28eb78ca34353347c3d4092e88f000c Mon Sep 17 00:00:00 2001

This is all garbled, not sure why your patch looks all messed up.

Are you using git sendemail or something manual?

  Luis

> 
> When the return code of "-ENOENT" was printed inside
> of the debug message, which could be hardcoded meaningfully.
> 
> Signed-off-by: John Zhao <yuankuiz@...eaurora.org>
> ---
>  drivers/base/firmware_loader/main.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/base/firmware_loader/main.c
> b/drivers/base/firmware_loader/main.c
> index 8e9213b..7eaaf5e 100644
> --- a/drivers/base/firmware_loader/main.c
> +++ b/drivers/base/firmware_loader/main.c
> @@ -328,12 +328,12 @@ fw_get_filesystem_firmware(struct device *device,
> struct fw_priv *fw_priv)
>                 rc = kernel_read_file_from_path(path, &fw_priv->data, &size,
>                                                 msize, id);
>                 if (rc) {
> -                       if (rc == -ENOENT)
> -                               dev_dbg(device, "loading %s failed with
> error %d\n",
> -                                        path, rc);
> -                       else
> +                       if (rc != -ENOENT)
>                                 dev_warn(device, "loading %s failed with
> error %d\n",
>                                          path, rc);
> +                       else
> +                               dev_dbg(device, "loading %s failed for no
> such file or directory.\n",
> +                                        path);
>                         continue;
>                 }
>                 dev_dbg(device, "direct-loading %s\n", fw_priv->fw_name);
> -- 
> 2.7.4
> 
> 
> On 2019-01-14 03:19 PM, yuankuiz@...eaurora.org wrote:
> > From d6892f54a81bf85ad011bfb8822567690713d575 Mon Sep 17 00:00:00 2001
> >