linux-kernel - Re: [PATCH v9 4/6] tpm: move tpm_chip definition to include/linux/tpm.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201902041630.P1UzejFY%fengguang.wu@intel.com>
Date:   Mon, 4 Feb 2019 16:58:21 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Roberto Sassu <roberto.sassu@...wei.com>
Cc:     kbuild-all@...org, jarkko.sakkinen@...ux.intel.com,
        zohar@...ux.ibm.com, david.safford@...com, monty.wiseman@...com,
        matthewgarrett@...gle.com, linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, keyrings@...r.kernel.org,
        linux-kernel@...r.kernel.org, silviu.vlasceanu@...wei.com,
        Roberto Sassu <roberto.sassu@...wei.com>
Subject: Re: [PATCH v9 4/6] tpm: move tpm_chip definition to
 include/linux/tpm.h

Hi Roberto,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on jss-tpmdd/next]
[also build test WARNING on next-20190204]
[cannot apply to v5.0-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Roberto-Sassu/tpm-retrieve-digest-size-of-unknown-algorithms-from-TPM/20190204-161932
base:   git://git.infradead.org/users/jjs/linux-tpmdd next
config: i386-randconfig-x006-201905 (attached as .config)
compiler: gcc-8 (Debian 8.2.0-14) 8.2.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

>> drivers/char/tpm/tpm_i2c_nuvoton.c:45: warning: "TPM_RETRY" redefined
    #define TPM_RETRY      5
    
   In file included from drivers/char/tpm/tpm_i2c_nuvoton.c:35:
   drivers/char/tpm/tpm.h:43: note: this is the location of the previous definition
    #define TPM_RETRY  50 /* 5 seconds */
    
--
   In file included from drivers/char/tpm/st33zp24/st33zp24.c:34:
>> drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
    #define TPM_BUFSIZE                     2048
    
   In file included from drivers/char/tpm/st33zp24/st33zp24.c:33:
   drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
    #define TPM_BUFSIZE  4096
    

vim +/TPM_RETRY +45 drivers/char/tpm/tpm_i2c_nuvoton.c

4c336e4b Jason Gunthorpe 2013-10-06  36  
4c336e4b Jason Gunthorpe 2013-10-06  37  /* I2C interface offsets */
4c336e4b Jason Gunthorpe 2013-10-06  38  #define TPM_STS                0x00
4c336e4b Jason Gunthorpe 2013-10-06  39  #define TPM_BURST_COUNT        0x01
4c336e4b Jason Gunthorpe 2013-10-06  40  #define TPM_DATA_FIFO_W        0x20
4c336e4b Jason Gunthorpe 2013-10-06  41  #define TPM_DATA_FIFO_R        0x40
4c336e4b Jason Gunthorpe 2013-10-06  42  #define TPM_VID_DID_RID        0x60
4c336e4b Jason Gunthorpe 2013-10-06  43  /* TPM command header size */
4c336e4b Jason Gunthorpe 2013-10-06  44  #define TPM_HEADER_SIZE        10
4c336e4b Jason Gunthorpe 2013-10-06 @45  #define TPM_RETRY      5
4c336e4b Jason Gunthorpe 2013-10-06  46  /*
4c336e4b Jason Gunthorpe 2013-10-06  47   * I2C bus device maximum buffer size w/o counting I2C address or command
4c336e4b Jason Gunthorpe 2013-10-06  48   * i.e. max size required for I2C write is 34 = addr, command, 32 bytes data
4c336e4b Jason Gunthorpe 2013-10-06  49   */
4c336e4b Jason Gunthorpe 2013-10-06  50  #define TPM_I2C_MAX_BUF_SIZE           32
4c336e4b Jason Gunthorpe 2013-10-06  51  #define TPM_I2C_RETRY_COUNT            32
a233a028 Nayna Jain      2017-03-10  52  #define TPM_I2C_BUS_DELAY              1000      	/* usec */
a233a028 Nayna Jain      2017-03-10  53  #define TPM_I2C_RETRY_DELAY_SHORT      (2 * 1000)	/* usec */
a233a028 Nayna Jain      2017-03-10  54  #define TPM_I2C_RETRY_DELAY_LONG       (10 * 1000) 	/* usec */
a233a028 Nayna Jain      2017-03-10  55  #define TPM_I2C_DELAY_RANGE            300		/* usec */
4c336e4b Jason Gunthorpe 2013-10-06  56  

:::::: The code at line 45 was first introduced by commit
:::::: 4c336e4b1556f4b722ba597bc6e3df786968a600 tpm: Add support for the Nuvoton NPCT501 I2C TPM

:::::: TO: Jason Gunthorpe <jgunthorpe@...idianresearch.com>
:::::: CC: Peter Huewe <peterhuewe@....de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (25076 bytes)