linux-kernel - Re: [PATCH v2] Bluetooth: Add NULL check for tiocmget() and tiocmset()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Feb 2019 10:22:16 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Myungho Jung <mhjungk@...il.com>
Cc:     Johan Hovold <johan@...nel.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Bluetooth: Add NULL check for tiocmget() and
 tiocmset()

On Mon, Feb 04, 2019 at 01:04:37AM -0800, Myungho Jung wrote:
> On Sun, Feb 03, 2019 at 11:29:00PM -0800, Myungho Jung wrote:
> > On Sun, Feb 03, 2019 at 11:53:23AM +0100, Johan Hovold wrote:

> > > You should add a Fixes tag identifying the commit which introduced each
> > > bug and a stable-cc tag. If you want you can indicate the version after
> > > a # sign, but that can also be inferred from the fixes tag.
> > > 
> > > For the hci_ldisc fix I think the tags would be:
> > > 
> > > 	Fixes: 2a973dfada2b ("Bluetooth: hci_uart: Add new line discipline enhancements")
> > > 	Cc: stable <stable@...r.kernel.org>     # 4.2
> > > 
> > > You can use git blame to track down the offending commits.
> > > 
> > > This should all be explained here:
> > > 
> > > 	https://www.kernel.org/doc/html/latest/process/submitting-patches.html

> I have one more question. The title of new patches should be version 3 like
> this?
> [PATCH v3] Bluetooth: hci_ath: ...
> [PATCH v3] Bluetooth: hci_ldisc: ...
> 
> Or newly start with [PATCH]?

You should keep and increment the revision number even if you split a
patch (so use v3 for the resend).

I suggest you send both patches in a series (as they are related); take
a look at git-send-email for a convenient way to do that. 

And always include a brief changelog (below the cut-off line, "---")
when revising patches.

Johan